Created attachment 69834 [details] [review]
a patch that seems to work for me

Did you really mean to patch Makefile.in (and not Makefile.am)?

Oh, the patch does that only because our spec doesn't run autotools.
Of course, you want to change Makefile.am.

We don't dist generated docs. That what we have in Makefile.am and I belive its correct:

if ENABLE_GTK_DOC
GTK_DOC_DIRS = libs
else
GTK_DOC_DIRS =
endif

if ENABLE_PLUGIN_DOCS
PLUGIN_DOCS_DIRS = plugins
else
PLUGIN_DOCS_DIRS =
endif

SUBDIRS = design $(GTK_DOC_DIRS) $(PLUGIN_DOCS_DIRS)
DIST_SUBDIRS = design libs plugins

Yeah you do:

$ tar tvjf gst-plugins-base-0.10.12.tar.bz2 | grep html
drwxrwxrwx 1000/1000         0 2007-03-07 16:38:09 gst-plugins-base-0.10.12/docs/libs/html/
-rw-r--r-- 1000/1000     93634 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/index.sgml
-rw-r--r-- 1000/1000     70600 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/api-index.html
-rw-r--r-- 1000/1000      4143 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/compiling.html
-rw-r--r-- 1000/1000      9884 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/gst-plugins-base-libs-gstaudioclock.html
-rw-r--r-- 1000/1000      8932 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/gst-plugins-base-libs-gstaudiofilter.html
-rw-r--r-- 1000/1000     16900 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/gst-plugins-base-libs-gstaudio.html
-rw-r--r-- 1000/1000      8312 2007-03-07 16:38:08 gst-plugins-base-0.10.12/docs/libs/html/gst-plugins-base-libs-gstaudiomixerutils.html
<snip>

Created attachment 88105 [details] [review]
patch for gstreamer

Here's a patch for gstreamer (not -base), which is essentially the same as the other patch.  This is what gtk+ does, seems like a good idea.  Needs someone to test a full distcheck + install of tarball.

I did a full distcheck and install with --disable-gtk-doc, and it works.  Applying (to gstreamer).  -base soon.

-base fixed now.  Closing.

I think this might have re-introduced bug #344039, ie:

... docs build ..
/usr/bin/python \
        ../../common/mangle-tmpl.py ./inspect tmpl
Traceback (most recent call last):

+ Trace 136792

make[4]: *** [tmpl-build.stamp] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

@tim: i belive thomas' python-based plugin-docs gtk-doc extension (the one that creates the executable that does introspection) needs a configure check for this python-xml module. the plugin docs should be disabled if not available.

Should this bug (or another) be open still?

Right, as the patch is commited and Bug #344039 is fixed it can be closed.