Bug 348821 – build failure

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 348821 - build failure


Summary:	build failure


Status:	RESOLVED FIXED

Product:	gnome-control-center
Classification:	Core
Component:	[obsolete] about-me
Version:	2.15.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Control-Center Maintainers
QA Contact:	Control-Center Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-07-26 18:20 UTC by Fryderyk Dziarmagowski
Modified:	2006-08-06 22:46 UTC

See Also:
GNOME target:	---
GNOME version:	2.15/2.16

Attachments
fix (1.25 KB, patch) 2006-07-26 21:34 UTC, Fryderyk Dziarmagowski	none	Details \| Review
patch from the Ubuntu package (1.41 KB, patch) 2006-07-28 10:32 UTC, Sebastien Bacher	committed	Details \| Review

Description Fryderyk Dziarmagowski 2006-07-26 18:20:29 UTC

if i686-pld-linux-gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../capplets/common -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/gconf2 -I/usr/include/orbit-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-desktop-2.0 -I/usr/include/startup-notification-1.0   -I../../ -DG_LOG_DOMAIN="\"-properties\"" -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -DORBIT2=1 -pthread -I/usr/include/evolution-data-server-1.8 -I/usr/include/libbonobo-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/orbit-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/gconf2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libxml2      -O2 -fno-strict-aliasing -fwrapv -march=i686 -mtune=pentium4 -ggdb -Wall -MT gnome-about-me.o -MD -MP -MF ".deps/gnome-about-me.Tpo" -c -o gnome-about-me.o gnome-about-me.c; \
        then mv -f ".deps/gnome-about-me.Tpo" ".deps/gnome-about-me.Po"; else rm -f ".deps/gnome-about-me.Tpo"; exit 1; fi
gnome-about-me.c: In function 'about_me_load_string_field':
gnome-about-me.c:388: warning: assignment discards qualifiers from pointer target type
gnome-about-me.c: In function 'about_me_load_photo':
gnome-about-me.c:422: error: 'EContactPhoto' has no member named 'length'
gnome-about-me.c:422: error: incompatible type for argument 2 of 'e_image_chooser_set_image_data'
gnome-about-me.c: In function 'about_me_update_photo':
gnome-about-me.c:493: error: incompatible types in assignment
gnome-about-me.c:494: error: 'EContactPhoto' has no member named 'length'
gnome-about-me.c:501: error: 'EContactPhoto' has no member named 'length'
gnome-about-me.c:501: error: incompatible type for argument 1 of 'fwrite'
make[3]: *** [gnome-about-me.o] Error 1

e-d-s 1.7.90.1

Comment 1 Fryderyk Dziarmagowski 2006-07-26 18:23:25 UTC

caused by :
http://bugzilla.gnome.org/show_bug.cgi?id=313533

Comment 2 Fryderyk Dziarmagowski 2006-07-26 18:23:54 UTC

changed version to 2.15.x

Comment 3 Fryderyk Dziarmagowski 2006-07-26 21:34:28 UTC

Created attachment 69691 [details] [review]
fix

Comment 4 Rodrigo Moya 2006-07-27 13:24:34 UTC

Diego, does this look ok to you?

Comment 5 Diego González 2006-07-27 17:17:43 UTC

yeah, please commit

Comment 6 Sebastien Bacher 2006-07-27 19:33:12 UTC

I think the patch is not 100% correct, if you create a new EContactPhoto you should set the type for it

Comment 7 Sebastien Bacher 2006-07-28 10:32:12 UTC

Created attachment 69809 [details] [review]
patch from the Ubuntu package

That's the patch I've used for the Ubuntu package

Comment 8 Sebastien Bacher 2006-08-06 22:46:40 UTC

I've commited the Ubuntu patch to the CVS now, marking as fixed