After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348753 - Accelerate key does not work in search bar
Accelerate key does not work in search bar
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.8.x
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-07-26 09:17 UTC by Boby Wang
Modified: 2013-09-13 00:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Patch for this bug (2.17 KB, patch)
2006-07-26 09:49 UTC, Boby Wang
none Details | Review
Update patch for this bug (1.98 KB, patch)
2006-07-26 12:06 UTC, Boby Wang
none Details | Review
what the entry look like (5.93 KB, image/jpeg)
2006-07-31 09:50 UTC, Li Yuan
  Details
the menu jump out when user click the magnifier (13.40 KB, image/jpeg)
2006-07-31 09:53 UTC, Li Yuan
  Details
the menu jump out when user click the right button (13.17 KB, image/jpeg)
2006-07-31 09:54 UTC, Li Yuan
  Details
new patch (2.02 KB, patch)
2006-08-21 08:21 UTC, Li Yuan
committed Details | Review

Description Boby Wang 2006-07-26 09:17:43 UTC
Please describe the problem:
In main view, User can not use accelerate key to change the option of search bar or clear the search bar.

Steps to reproduce:
1. Lanuch Evolution
2. Goto the mail view
3. Use keyboard to open the option window of search bar, then select "Message Contains" option item. [ALT + somekey]
4. Use keyboard to clear the search bar [ALT + c]


Actual results:
Step 3 and 4 can not be completed by keyboard, because any key combination will do  that.

Expected results:
Step 3 and 4 can be done by pressing some accelerate key.

Does this happen every time?
yes

Other information:
Comment 1 Boby Wang 2006-07-26 09:49:50 UTC
Created attachment 69652 [details] [review]
Patch for this bug
Comment 2 Li Yuan 2006-07-26 09:56:41 UTC
User can select search option menu or clear "button" only by mouse. They should have shortcut key.
Comment 3 Johnny Jacob 2006-07-26 10:49:01 UTC
alt+down for poping the menu is cool .. But not sure abt using 'alt+c' for clearing the search. currently, 'ctrl+shift+q' clears the search. 

adding srini on cc list.
Comment 4 Boby Wang 2006-07-26 12:06:47 UTC
Created attachment 69658 [details] [review]
Update patch for this bug

CTRL+SHIFT+q works for clear button, so ALT+c has been removed from the patch
Comment 5 Srinivasa Ragavan 2006-07-26 16:22:45 UTC
Looks cool. Does this break UI freeze? 
Comment 6 Li Yuan 2006-07-27 09:11:17 UTC
Hi Calum, I have a problem here. There is a gtk-event-box with a image in Evolution, when user press the eventbox, Evolution will popup a gtk-menu. Now, we want to add a shortcut key for the  eventbox. What shortcut key should we use?
Comment 7 Calum Benson 2006-07-31 09:19:10 UTC
Shift-F10 is the usual shortcut for activating a popup menu.

However, from reading the above comments, it's not clear to me exactly which control/popup menu in Evolution you're talking about.  Can you clarify which control will have the keyboard focus when you want this shortcut to be active?  It might be that Shift-F10 isn't appropriate in this case.
Comment 8 Li Yuan 2006-07-31 09:50:51 UTC
Created attachment 69951 [details]
what the entry look like
Comment 9 Li Yuan 2006-07-31 09:53:50 UTC
Created attachment 69952 [details]
the menu jump out when user click the magnifier
Comment 10 Li Yuan 2006-07-31 09:54:42 UTC
Created attachment 69953 [details]
the menu jump out when user click the right button
Comment 11 Li Yuan 2006-07-31 09:58:11 UTC
I pasted the screenshot. As you see, the "magnifier" is only a eventbox, not button. So it will not get focus. What we want to do is when the right entry get the focus, there is a shortcut key for the "magnifier". shift + f10 is for the 3rd screenshot's menu already.
Comment 12 André Klapper 2006-08-01 14:56:09 UTC
hmm... i wonder if alt+arrowdown (which is used in the patch) is allowed by the HIG...
http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html :
"Do not use Alt-key combinations for shortcut keys, as these may conflict with window manager or menu access keys."

:-/
Comment 13 Calum Benson 2006-08-01 17:38:37 UTC
The HIG is talking about shortcut keys for menu items there, so you don't need to worry about that :)

Ok, well I think Alt-Down is a reasonable choice, as that's the shortcut for dropping down a combo box, and it's also the shortcut that Thunderbird uses in this exact same situation.

It would also be nice if the magnifier icon had a little 'down arrow', like the Thunderbird icon has, to give a visual suggestion that there are some dropdown options available.
Comment 14 Li Yuan 2006-08-02 05:48:57 UTC
Thank you Calum. So Johnny, can we commit the boby's patch in comment#4 first? And then we can try to find out some icon which has down arrow.
Comment 15 Harish Krishnaswamy 2006-08-04 09:49:14 UTC
Add keyword 'usability' and re-assign to the relevant owner.
Comment 16 André Klapper 2006-08-06 12:50:27 UTC
trying to find out some icon which has a down arrow is now bug 349935.
Comment 17 Srinivasa Ragavan 2006-08-19 18:14:28 UTC
As I have pointed above, this might break UI freeze. (Adding a new shortcut/key).
Please request for a freeze break.
Comment 18 André Klapper 2006-08-20 11:30:16 UTC
request for freeze break has been sent to the mailing lists by jeff cai.
Comment 19 Vincent Untz 2006-08-21 07:12:01 UTC
I believe this line of the patch

+	if (key_event->state & GDK_MOD1_MASK

should be:

+	if ((key_event->state & gtk_accelerator_get_default_mod_mask ()) ==  GDK_MOD1_MASK
Comment 20 Li Yuan 2006-08-21 08:21:12 UTC
Created attachment 71283 [details] [review]
new patch
Comment 21 Srinivasa Ragavan 2006-11-22 18:49:19 UTC
Fixed