After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348733 - keyboard shortcuts interfere when entering comments
keyboard shortcuts interfere when entering comments
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.1.11
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 348772 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-26 04:28 UTC by Alexander Kirillov
Modified: 2006-08-11 16:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
small fix (2.31 KB, patch)
2006-07-26 20:54 UTC, Thomas Van Machelen 		none Details | Review

Description Alexander Kirillov 2006-07-26 04:28:19 UTC 
When entering comments to a photo, keys [ and ] rotate the photo, making it impossible to enter a comment containing these symbols. Worse, this happens regrdless of keyboard laypout used. For example, I use Russian typewriter layout, in which key [ generates Cyrillic letter "х". Thus, this bug makes it impossible to enter comments containing this letter.

I think no one would really miss it if all kbd shortcuts were disabled when in comment editing mode
Comment 1 Stephane Delcroix 2006-07-26 14:21:34 UTC 
*** Bug 348772 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Van Machelen 2006-07-26 20:54:05 UTC 
Created attachment 69688 [details] [review]
small fix

This patch removes the ] and [ accelerator keys from the glade file and implements  them in the HandleIconViewPressEvent and HandleIconViewPressEvent methods.  Like that you can enter the special characters in the description field without a rotation taking effect.

The disadvantage is that the accelerator keys are no longer visible in the menu, which makes them less discoverable (or can this be done without an actual key binding?).  Another approach would be to alter the accelerators.
Comment 3 Gabriel Burt 2006-08-11 16:38:09 UTC 
I wrote and committed a patch for this that just checks if the currently focused widget is an Entry (and the current event a key press) before handling the rotations.  Thanks guys.