After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348675 - RTP timestamps incorrectly generated for G711
RTP timestamps incorrectly generated for G711
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-25 18:21 UTC by Kai Vehmanen
Modified: 2009-08-10 23:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Patch that attempts to fix the described problem (3.47 KB, patch)
2006-07-25 18:22 UTC, Kai Vehmanen 		committed Details | Review

Description Kai Vehmanen 2006-07-25 18:21:43 UTC 
Please describe the problem:
The PCMU and PCMA payloaders incorrectly increase the RTP timestamps in consecutive packets when max-ptime is set.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Kai Vehmanen 2006-07-25 18:22:33 UTC 
Created attachment 69598 [details] [review]
Patch that attempts to fix the described problem
Comment 2 Wim Taymans 2006-07-26 16:37:15 UTC 
Also changed the duration calculation based on incomming buffer size instead of TIMESTAMP (?!?). Used _scale function to avoid overflows. 

        Patch by: Kai Vehmanen <kv2004 at eca dot cx>

        * gst/rtp/gstrtppcmapay.c: (gst_rtp_pcma_pay_flush),
        (gst_rtp_pcma_pay_handle_buffer):
        * gst/rtp/gstrtppcmupay.c: (gst_rtp_pcmu_pay_flush),
        (gst_rtp_pcmu_pay_handle_buffer):
        Fix timestamp calculation on outgoing RTP packets.
        Fixes #348675.