After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348639 - Help kill libegg
Help kill libegg
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Typing break
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hult
Control-Center Maintainers
: 340103 (view as bug list)
Depends on:
Blocks: 349256
 
 
Reported: 2006-07-25 13:52 UTC by Vincent Untz
Modified: 2006-07-30 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (8.33 KB, patch)
2006-07-25 13:52 UTC, Vincent Untz
none Details | Review

Description Vincent Untz 2006-07-25 13:52:11 UTC
We should use GtkStatusIcon.

Here's a patch to help kill libegg proliferation. The egg files should also be
removed. And I guess you'd also need to check for GTK+ 2.10 in configure.in...
Comment 1 Vincent Untz 2006-07-25 13:52:36 UTC
Created attachment 69580 [details] [review]
patch
Comment 2 Vincent Untz 2006-07-25 13:53:56 UTC
Hrm. There's also a patch in bug 340103.
Comment 3 Richard Hult 2006-07-25 13:57:09 UTC
Thanks. This one looks better at a first glance as it handles the popup menu the right way (just looked very quickly, might be wrong). If someone could commit this, I wouldn't mind. I won't really have time to look at it myself though (I have no 2.15 environment setup at all).
Comment 4 Rodrigo Moya 2006-07-25 19:33:47 UTC
Ok, committed to HEAD
Comment 5 Christian Persch 2006-07-28 12:18:44 UTC
Thanks for ignoring my work in bug 340103, it's not like it's been sitting there ignored for months...

(In reply to comment #3)
> This one looks better at a first glance as it handles the popup menu
> the right way (just looked very quickly, might be wrong).

What do you mean by that? My patch also used gtk_status_icon_position_menu.
Comment 6 Christian Persch 2006-07-28 12:19:30 UTC
*** Bug 340103 has been marked as a duplicate of this bug. ***
Comment 7 Richard Hult 2006-07-28 12:27:02 UTC
Sorry if I hurt your feelings, but I did say "just looked very quickly, might be wrong". I really meant that.