Created attachment 69487 [details] [review]
Implementation of the missing function

I have no say in the Quartz backend, but allocating a 4-byte array on the heap for every pixel in the image is not a great idea.

@Ross Burton : yes you're right, it is an error. I didnt fix it but the performance will be better

Another issue is that it only works for pixmaps, not windows (the drawable can be both).

I've committed the other part of this, copying from a window. The pixmap part still needs to be implemented.

Created attachment 92175 [details] [review]
Another try for pixmap to image copy

At least the 24 bit case does work (tested with GKrellM).
The other two cases are based on what I read in gdk_pixmap_new() in gdkpixmap-quarz.c.

Thanks, looks nice. I assume you mean image->depth, the pixmap doesn't have that field so it doesn't build.

II was looking to build gkrellm to test the patch on ppc too, but I can't seem to build it without X. Is there a patched version I can try?

Thanks, commited with the above mentioned fix (image->depth).