After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348423 - Black background for browse/edit modes
Black background for browse/edit modes
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
0.1.11
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-23 15:52 UTC by Jose Alberto
Modified: 2008-05-19 11:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Make the browse and 'edit' mode background black (1.88 KB, patch)
2006-09-10 23:05 UTC, Gabriel Burt
rejected Details | Review
Screenshot showing the patch in use (172.00 KB, image/png)
2006-09-10 23:07 UTC, Gabriel Burt
  Details
Dark theme using the mist engine (clearlooks HEAD has a slight problem with gradients) (5.55 KB, text/x-gtkrc)
2006-09-22 14:34 UTC, Jakub Steiner
  Details
screenshot of the theme in action (584.63 KB, image/png)
2006-09-22 14:39 UTC, Jakub Steiner
  Details

Description Jose Alberto 2006-07-23 15:52:51 UTC
Can be really nice a new config dialog to select the background and border of the browser mode. A lot of us prefer dark backgorunds to watch picts. Yes i tried several dark gtk-themes and the no change this zones.
Comment 1 Gabriel Burt 2006-09-10 23:05:41 UTC
Created attachment 72516 [details] [review]
Make the browse and 'edit' mode background black

I really like how this looks.  It would be easy to add this as a preference, of course, but first we should discuss if this should become the default/only option.
Comment 2 Gabriel Burt 2006-09-10 23:07:54 UTC
Created attachment 72517 [details]
Screenshot showing the patch in use
Comment 3 Larry Ewing 2006-09-11 01:38:19 UTC
This isn't the way this should be done, you should use te gtkstyle mechanism to do it.  You can make f-spot generate and read a custom gtkrc file.  This avoids potential conflicts with theme settings.  I have an old patch I wrote to do black backgrounds in image area I'll see if I can dig it up.  It's worth noting that f-spot had a dark gray color in the image area backgrounds in its early days and I changed it to respect the theme.  I'd lean towards making a custom dark theme just (jimmac and I worked on this for a while) rather than just overriding particular widgets.
Comment 4 Michael Monreal 2006-09-11 11:15:44 UTC
I don't really like the black background (wouldn't improve usablity for me and it doesn't fit the rest of the application very well)

I remember screenshots of the dark-grey background, this looked better to me than the black.

Anyway, instead of just changing the color, I think the whole image display area should be reworked to be more like a nautilus folder view, supporting rubberbanding and stuff like that, also perhaps allowing a folder view for those who prefer showing the on-disk structure of the photo collection.
Comment 5 Jakub Steiner 2006-09-22 14:32:45 UTC
Attached is a dark gtkrc theme I have been using lately. 

You can apply it only for f-spot with:

`GTK2_RC_FILES=$HOME/.themes/DarkMist/gtk-2.0/gtkrc f-spot`
Comment 6 Jakub Steiner 2006-09-22 14:34:22 UTC
Created attachment 73214 [details]
Dark theme using the mist engine (clearlooks HEAD has a slight problem with gradients)
Comment 7 Jakub Steiner 2006-09-22 14:38:24 UTC
I forgot to note the gtkrc is work in progress. It doesn't work with the image preview which is still white. Also the text entry for comments is broken, and should be light.
Comment 8 Jakub Steiner 2006-09-22 14:39:19 UTC
Created attachment 73215 [details]
screenshot of the theme in action
Comment 9 Stephane Delcroix 2008-05-05 09:47:02 UTC
r3865 allow custom theme loading