After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348416 - remuxer example should use normal seek
remuxer example should use normal seek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: Andy Wingo
Johan (not receiving bugmail) Dahlin
Depends on:
Blocks:
 
 
Reported: 2006-07-23 13:56 UTC by James "Doc" Livingston
Modified: 2006-07-28 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.35 KB, patch)
2006-07-23 14:04 UTC, James "Doc" Livingston
committed Details | Review

Description James "Doc" Livingston 2006-07-23 13:56:47 UTC
The ogg remuxer example (gst-python/examples/remuxer.py) should use a normal seek, not a segment seek, as that would make it send EOS and allow oggmux (et al) to clean up correctly.

In the current version, using a segment seek, oggmux does not receive an EOS event or have it's sinkpads removed correctly. This can cause it to loose data, and with my oggmux patch from bug 337026 definitely will.
Comment 1 James "Doc" Livingston 2006-07-23 14:04:14 UTC
Created attachment 69419 [details] [review]
patch

This patch works from my very quick testing
Comment 2 Zaheer Abbas Merali 2006-07-25 19:02:03 UTC
guess thins should be assigned to wingo
Comment 3 Andy Wingo 2006-07-26 08:56:11 UTC
Patch looks fine. Go ahead and apply, or poke me if you need me to do that.
Comment 4 Andy Wingo 2006-07-28 13:57:04 UTC
2006-07-28  Andy Wingo  <wingo@pobox.com>

	* examples/remuxer.py (RemuxBin._do_seek, Remuxer._bus_watch): Use
	normal seeks instead of segment seeks so that EOS is handled
	properly. Patch by James "Doc" Livingston <doclivingston at
	gmail.com>. (#348416)


Thanks!