GNOME Bugzilla – Bug 348416
remuxer example should use normal seek
Last modified: 2006-07-28 13:58:16 UTC
The ogg remuxer example (gst-python/examples/remuxer.py) should use a normal seek, not a segment seek, as that would make it send EOS and allow oggmux (et al) to clean up correctly. In the current version, using a segment seek, oggmux does not receive an EOS event or have it's sinkpads removed correctly. This can cause it to loose data, and with my oggmux patch from bug 337026 definitely will.
Created attachment 69419 [details] [review] patch This patch works from my very quick testing
guess thins should be assigned to wingo
Patch looks fine. Go ahead and apply, or poke me if you need me to do that.
2006-07-28 Andy Wingo <wingo@pobox.com> * examples/remuxer.py (RemuxBin._do_seek, Remuxer._bus_watch): Use normal seeks instead of segment seeks so that EOS is handled properly. Patch by James "Doc" Livingston <doclivingston at gmail.com>. (#348416) Thanks!