After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348300 - Missing #include
Missing #include
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
2.16.x
Other Mac OS
: Normal trivial
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-21 21:51 UTC by Daniel Macks
Modified: 2007-02-06 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the build on OSX (373 bytes, patch)
2007-01-21 17:46 UTC, Christian Kirbach
none Details | Review

Description Daniel Macks 2006-07-21 21:51:44 UTC
nautilus-2.14.1 (and the code is the same as CVS HEAD) can't be built on OS X 10.3 using Apple's gcc3.3:

 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -I../cut-n-paste-code -DORBIT2=1 -I/sw/include/startup-notification-1.0 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/orbit-2.0 -I/sw/include/bonobo-activation-2.0 -I/sw/include/gconf/2 -I/sw/include/libbonobo-2.0 -I/sw/include/gnome-vfs-2.0 -I/sw/include/gnome-vfs-module-2.0 -I/sw/lib/gnome-vfs-2.0/include -I/sw/include/pango-1.0 -I/usr/X11R6/include -I/usr/X11R6/include/freetype2 -I/sw/include/gtk-2.0 -I/sw/include/atk-1.0 -I/sw/lib/gtk-2.0/include -I/sw/include/libart-2.0 -I/sw/include/libgnome-2.0 -I/sw/include/libgnomecanvas-2.0 -I/sw/include/libxml2 -I/sw/include -I/sw/include/gnome-keyring-1 -I/sw/include/libbonoboui-2.0 -I/sw/include/libgnomeui-2.0 -I/sw/include/gnome-desktop-2.0 -I/sw/include/librsvg-2 -I/sw/include/libglade-2.0 -I/sw/include/gail-1.0 -I/sw/include/eel-2 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/pango-1.0 -I/usr/X11R6/include -DDATADIR=\"/sw/share\" -DSYSCONFDIR=\"/sw/etc\" -DNAUTILUS_DATADIR=\"/sw/share/nautilus\" -DNAUTILUS_EXTENSIONDIR=\"/sw/lib/nautilus/extensions-1.0\" -I/sw/include -g -O2 -c nautilus-emblem-utils.c  -fno-common -DPIC -o .libs/nautilus-emblem-utils.o
In file included from nautilus-emblem-utils.c:27:
/usr/include/utime.h:62: error: parse error before "time_t"
nautilus-emblem-utils.c: In function `nautilus_emblem_install_custom_emblem':
nautilus-emblem-utils.c:233: error: storage size of `ubuf' isn't known
nautilus-emblem-utils.c: In function `nautilus_emblem_remove_emblem':
nautilus-emblem-utils.c:343: error: storage size of `ubuf' isn't known
nautilus-emblem-utils.c: In function `nautilus_emblem_rename_emblem':
nautilus-emblem-utils.c:392: error: storage size of `ubuf' isn't known
make[2]: *** [nautilus-emblem-utils.lo] Error 1

Here's the fix: for libnautilus-private/nautilus-emblem-utils.c,

 #include <config.h>
 
+#include <sys/types.h>
 #include <sys/utime.h>
 #include <stdio.h>
Comment 1 Christian Kirbach 2007-01-21 17:44:00 UTC
we are sorry that his has been for some time

is this still an issue? adding the include line does at least not hurt the Linux build.

Comment 2 Christian Kirbach 2007-01-21 17:46:18 UTC
Created attachment 80821 [details] [review]
fix the build on OSX

fixes the buidl for OSX, as suggested by dmacks netspace.org
Comment 3 Alexander Larsson 2007-02-06 13:19:09 UTC
Commited. thanks.