GNOME Bugzilla – Bug 348268
Missing Git Better Detected
Last modified: 2007-02-09 19:13:57 UTC
I'm using jhbuild for the first time and spent a lot of time understanding the message I was seeing when it got to the sites that use git to bring down code. The error seemed to imply that the site itself was down, rather than that the program itself was missing. Shouldn't sanitycheck check for software packages missing that are required to bring down modules? Other information:
*** Bug 348321 has been marked as a duplicate of this bug. ***
Created attachment 69405 [details] [review] Check for cvs, svn, and git in sanitycheck. Check the user has: - cvs (most people get jhbuild from cvs, so this should be installed, but no harm having it anyway) - svn - git
*** Bug 348548 has been marked as a duplicate of this bug. ***
Patch looks fine and useful; James, ok to commit ?
Changing the patch status from 'reviewed'[1] to 'none' so that it'll show up in the list of patches that James needs to review (e.g. on browse.cgi). I agree with Frederic that the patch looks good. :) [1] 'commented-on' was misnamed and thus misused so I renamed it recently to 'reviewed'. What many people thought it was for is actually something we just don't have yet, namely, a 'pseudo-reviewed' state. That'll be added at some point; hopefully with the PatchSquad (live.gnome.org/PatchSquad) starting up.
The patch looks okay, but I think we need to do a better check for git. There is another tool called "git" that a number of people have managed to install instead (it is a text mode file manager). It would be good if the check made sure they didn't have that git installed.
Created attachment 70765 [details] [review] Also checks is git is the right git Checking 'git --help' yields 'clone' in its output; this should insure git is the right git.
I just commited something similar to the last patch (just added a check for subversion).