GNOME Bugzilla – Bug 347972
[cdiocddasrc] core dumps if device is not found
Last modified: 2006-07-19 07:37:02 UTC
I notice that if the device passed to CDDA is not found, it triggers an assert in the close function, causing the program to crash. Programs like gnome-cd work better if they don't crash, since the device can be changed in the Preferences. Attaching patch to remove the assert, which I don't think really adds any value.
Created attachment 69150 [details] [review] patch to remove assert
Thanks for the patch, but I've already removed this assert in CVS last week when you mentioned it on IRC: 2006-07-11 Tim-Philipp Müller <tim at centricular dot net> * ext/cdio/gstcdiocddasrc.c: (gst_cdio_cdda_src_close): Remove g_assert that shouldn't be there. > Programs like gnome-cd work better if they don't crash No kidding :)