After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347967 - doesn't follow theme colours
doesn't follow theme colours
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2006-07-18 22:15 UTC by Christian Persch
Modified: 2007-05-16 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (718 bytes, patch)
2006-07-18 22:21 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-07-18 22:15:58 UTC 
Steps:
0) Switch theme to HighContrastInverse
1) Start devhelp and load some doc page

Actual result:
Glaring white background with black text!

Expected result:
White text on dark blue background.
Comment 1 Christian Persch 2006-07-18 22:21:46 UTC 
Created attachment 69144 [details] [review]
fix

Always use the theme colours
Comment 2 Richard Hult 2006-07-27 08:04:44 UTC 
Thanks! Please commit :)
Comment 3 Christian Persch 2006-07-27 23:01:44 UTC 
I committed the patch.

But it turns out it causes a problem on gecko < 1.9: the headers on the gtk API docs pages become transparent and when you scroll down, the text shows up under them...
Comment 4 Richard Hult 2006-07-28 07:40:13 UTC 
Ah, should we make it conditional only for >= 1.9? I need to make a new release I guess.
Comment 5 Christian Persch 2006-07-28 12:07:53 UTC 
Yes, that's easily possible.
Comment 6 Richard Hult 2006-08-03 07:39:57 UTC 
I've commented out the document color setting for now, and will make a release.
Comment 7 Hans Nieser 2006-09-17 16:17:46 UTC 
I'm not sure what happened with this patch and wether it checks the gecko version, but I am currently using devhelp-0.12, linked against firefox 1.5.0.7, and I still get the 'transparant headers' issue (as well as monospaced font refusing to become anti-aliased, no matter what font I select in the font selector, though this is maybe a separate issue). Is this to be expected or a bug?
Comment 8 Richard Hult 2006-09-17 16:35:32 UTC 
The patch is in CVS (or rather the patch has been reverted in CVS), but no release has been made yet.
Comment 9 Richard Hult 2007-04-20 17:07:21 UTC 
I committed a variant that makes the setting only apply for gecko 1.9 and later. I'm not sure if that will help anyone as even feisty only has 1.8 as far as I can see though :(
Comment 10 Christian Persch 2007-05-16 21:39:49 UTC 
Just for reference, the gecko bug about the transparent headers was https://bugzilla.mozilla.org/show_bug.cgi?id=255411 .