GNOME Bugzilla – Bug 347913
left button on tray applet
Last modified: 2006-09-22 19:30:37 UTC
I suppose we should make clicking with the left button on the tray applet do something. I thought we had it doing the same as the right click...
Depends if you are using the libegg code or the GtkStatusIcon code. The GtkStatusIcon code just uses the defaults which I think is sane.
I also believe it should do something for left click - most other stuff on my system tray does, and its kind of frustrating to click the icon and not getting any feedback. I think that ultimately you want to have a left click menu with just the actions (suspend, hibernate, whatever) and maybe the "information" button - in contrast to the RMB menu which offers preferences, help and about.
Oded, that sounds sane IMO, but we should wait until 2.17 opens as this will upset the freeze people :-) When 2.17 is branched, I'll make the change you suggest, and see what the feedback is. Jon, do you agree?
BTW - this issue seems to be related to Bug 331478, which - they way I'm reading it - suggest that this was indeed a problem in the past that was fixed, so that the current status is a revert. I don't remember how g-p-m used to work in 2.14 (before I started using all this bleeding edge stuff ;-) ), but I have a laptop at home that still uses FC5 that I can check and get back about it later.
This is indeed works in g-p-m version 2.14.3 that is included in Fedora Core 5 - left click and right click open the same menu, and the current behavior is a revert. Like I stated above - I think the LMB menu should be simpler then the RMB menu, but if thats a problem with the freeze policy then I think it should at least be fixed to work like in 2.14, and made simpler in 2.17 like you suggested. Thanks.
Oded, that depends on if you are using the GtkStatusIcon or eggtrayicon code - there's already ifdefs to cover both cases, and adding further code would complicate matters even more, which I'm not keen on doing this close to the hard code freeze. We can sort this properly in the 2.17 series when we can depend on GtkStatusIcn and drop eggtrayicon completely.
I'm using gnome-power-manager 2.15.91 from Fedora Core development (currently at post test 2), and I think it uses eggtrayicon (strings /usr/bin/gnome-power-manager shows eggtrayicon and doesn't show GtkStatusIcn). If I understand correctly, eggtrayicon is the old method, and so should work as it did previously, right ?
Ohh, fc-rawhide will be using GtKStatusIcon for sure. eggtrayicon is still linked in for 2.16, but that's due to another bug that I can't fix yet.
So, now I have a working gtk 2.10, I can play properly with GtkStatusIcon. The correct action is to do of left click ***** Suspend Hibernate --------- Preferences Information ***** and on right click ***** Help About ***** Right?
I would say that "preferences" is an RMB action, possibly "information" as well.
Please see http://hughsient.livejournal.com/3842.html
2006-09-22 Richard Hughes <richard@hughsie.com> * src/gpm-tray-icon.c: Move Help, About, Statistics and Preferences to right mouse button action to fix #347913.