After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347899 - Add more mutators to EVCard
Add more mutators to EVCard
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-07-18 11:00 UTC by Ross Burton
Modified: 2013-09-14 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.09 KB, patch)
2006-07-18 11:02 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2006-07-18 11:00:40 UTC 
As the GLists holding the value lists are private in EVCard, writing code to manipulate EVCards intensively is quite an exercise in futility.

Attaching a patch to add methods to remove values from various parts of the EVCard structure.
Comment 1 Ross Burton 2006-07-18 11:02:08 UTC 
Created attachment 69102 [details] [review]
Patch

This patch is well-tested, as it's in heavy use on the Nokia 770.
Comment 2 Devashish Sharma 2006-07-24 06:01:02 UTC 
looks good, can be committed, but i dont see the need to use 'goto' here.

instead of g_ascii_strcasecmp ()
            goto 

why dont g_ascii_strcasecmp ()
          remove the value here only;
Comment 3 Ross Burton 2006-07-24 08:44:56 UTC 
Removed the use of goto and committed to HEAD, thanks.