GNOME Bugzilla – Bug 347898
[id3v2mux] write GST_TAG_ENCODER and GST_TAG_ENCODER_VERSION
Last modified: 2006-07-19 12:24:11 UTC
Attached patch fixes this.
Created attachment 69100 [details] [review] Writes TENC ID3 tag This writes GST_TAG_ENCODER and GST_TAG_ENCODER_VERSION to TENC in the format: GST_TAG_ENCODER GST_TAG_ENCODER_VERSION it appends the name of the actual gstreamer plugin name and version "id3v2mux 0.10.3.1" in brackets after the application name, so for example called from a rhythmbox encoding pipeline it would look like this: "Rhythmbox 0.9.5 (id3v2mux 0.10.3.1)"
I have no problems with the patch as such, but just out of curiosity - is this how the TENC/GST_TAG_ENCODER tag is commonly used (or supposed to be used)? The id3v2 spec says: TENC The 'Encoded by' frame contains the name of the person or organisation that encoded the audio file. This field may contain a copyright message if the audio file is also copyrighted by the encoder. Rhythmbox/sound-juicer aren't really "the person or organisation" that encoded the file, is it? Even less so an application just re-tagging the file.
Dunno. I do know that iTunes regularly uses TENC to indicate what version of the iTunes client ripped a CD. If you look at TENC for most iTunes ripped MP3s it will have something like "iTunes 6.0.1".
Currently rhythmbox sets GST_TAG_ENCODER to "Rhythmbox", which ID3 tag that should be mapped to is unclear. Perhaps it should be to TSSE: TSSE The 'Software/Hardware and settings used for encoding' frame includes the used audio encoder and its settings when the file was encoded. Hardware refers to hardware encoders, not the computer on which a program was run.
Ah, thanks for checking, TSSE seems indeed more appropriate to me. Committed your patch with the following modifications: - if we have ENCODER_VERSION but no ENCODER, just skip it - don't add "(id3v2mux foobar)" bit to tag string; I think the element should write the tag unmodified as it is passed to it (makes retagging/rewriting less messy as well). Still, it might make sense to add this kind of information somewhere at some point (maybe into a custom TXXX frame or comment?) 2006-07-19 Tim-Philipp Müller <tim at centricular dot net> Patch by: Alex Lancaster <alexl at users sourceforge net> * ext/taglib/gstid3v2mux.cc: Write GST_TAG_ENCODER and GST_TAG_ENCODER_VERSION as ID3v2 TSSE frames (#347898). Also updated -base so that id3demux reads the tag: 2006-07-19 Tim-Philipp Müller <tim at centricular dot net> * gst-libs/gst/tag/gstid3tag.c: Add TSSE <=> GST_TAG_ENCODER mapping (see #347898).