After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347782 - evolution shows gpg/pgp encrypted error message as s/mime
evolution shows gpg/pgp encrypted error message as s/mime
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.12.x
Other Linux
: Normal trivial
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-07-17 13:47 UTC by Daniel Holbach
Modified: 2013-09-13 00:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
bug 347782 -- changed error messages to correctly refer to GPG (1.28 KB, patch)
2007-07-06 21:20 UTC, C de-Avillez
none Details | Review
revised patch (1.28 KB, patch)
2007-07-06 22:04 UTC, C de-Avillez
committed Details | Review

Description Daniel Holbach 2006-07-17 13:47:29 UTC
Forwarded from: https://launchpad.net/distros/ubuntu/+source/evolution/+bug/52804

When I opened a gpg/pgp encrypted message and clicked cancel when it asked for my passphrase, evolution showed the error message "Could not parse S/MIME message \n User canceled operation." in red where the message usually would be. This should say "Could not parse PGP message..." or similar.
Comment 1 Karsten Bräckelmann 2006-07-18 11:42:34 UTC
Confirming.
Comment 2 André Klapper 2006-07-18 14:28:30 UTC
i still wonder where this message is exactly located...
it obviously is not translated, which would be another bug.

once upon a time it was in mail/em-format-html.c according to
http://mail.gnome.org/archives/gnome-i18n/2005-August/msg00209.html
Comment 3 C de-Avillez 2007-07-06 17:20:02 UTC
I found it in mail/em-format.c, at revision 3368 (current head). And indeed it is not being marked for translation.

Since I am unsure on what to do here -- is it to be changed or not? I am refraining from sending a patch. It seems, to me, that changing the string would also be the moment to i18n it, so this bug might do both.

The string occurs in two places, both not marked for translation, in emf_inlinepgp_encrypted and in emf_multipart_encrypted. Both deal with GPG/PGP.
Comment 4 Jeffrey Stedfast 2007-07-06 17:30:04 UTC
careful with emf_multipart_encrypted() as it also handles S/MIME there
Comment 5 C de-Avillez 2007-07-06 19:09:52 UTC
yes, I noticed it. Nevertheless, at this point it is dealing with GPG only:

(...)
	ex = camel_exception_new();
	context = camel_gpg_context_new(emf->session);
	opart = camel_mime_part_new();
	valid = camel_cipher_decrypt(context, part, opart, ex);
	if (valid == NULL) {
		em_format_format_error(emf, stream, ex->desc?("Could not parse S/MIME message"):_("Could not parse S/MIME message: Unknown error"));
		if (ex->desc)
			em_format_format_error(emf, stream, ex->desc);
		em_format_part_as(emf, stream, part, "multipart/mixed");
(...)

Anyways, I do not know what is actually expected to be done, as I noted above, to risk a patch here.... sorry.
Comment 6 Jeffrey Stedfast 2007-07-06 20:13:02 UTC
just add an _ before the ("Could not parse S/MIME message")

looks like someone simply typoed
Comment 7 C de-Avillez 2007-07-06 21:20:08 UTC
Created attachment 91323 [details] [review]
bug 347782 -- changed error messages to correctly refer to GPG

Proposed patch attached. This will add 2 new i18n strings (previously untranslated) and replace 2 existing ones.

Patched against revision 33628 of mail/em-format.c
Comment 8 Jeffrey Stedfast 2007-07-06 22:00:20 UTC
instead of "GPG/PGP", I'd probably say "PGP/MIME" for the multipart callback and for the inline callback, I'd probably just say PGP
Comment 9 C de-Avillez 2007-07-06 22:04:58 UTC
Created attachment 91326 [details] [review]
revised patch

revised patch per Jeffrey's comments.
Comment 10 Jeffrey Stedfast 2007-07-07 00:33:10 UTC
awesome, thanks. looks good to me now...

I'm not sure if evo is string frozen or not atm tho, will let the current mail maintainers commit
Comment 11 Srinivasa Ragavan 2007-07-09 02:51:35 UTC
Fejj, we still have a few weeks before the freeze, so no probs :)

Committed to head.