GNOME Bugzilla – Bug 347717
URI fragment identifier used in GNOMEVFS HTTP requests
Last modified: 2006-08-25 07:23:06 UTC
Please describe the problem: URI fragment identifiers are being used in HTTP requests. The "path" we pass to neon contains more than just the path. This causes 404's when trying to retrieve files with fragments in their URIs via GNOMEVFS, as the request line looks something like this: GET /#somefrag HTTP/1.1 Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 69011 [details] [review] Patch against CVS HEAD In http_context_set_uri Renamed "uri_string" symbol to "uri_path" as it is a much more accurate description of what the variable contains. Added GNOME_VFS_URI_HIDE_FRAGMENT_IDENTIFIER to the "gnome_vfs_uri_to_string" call so that all parts except the path are correctly omitted.
Is everything OK with this? Should I patch against a different version?
Just to clarify, when asking GNOME-VFS to retrieve a resource by URI of the form <http://authority/resource#fragment>, my patch actually returns data for <http://authority/resource> and with the assumption that it is the responsibility of the application to deal with resource fragment resolution. This is what we want, right?
Created attachment 71407 [details] [review] Fix Removed the change of terminology - I don't think it's worth worrying right now, as we have no distinction between URIs and URI references in GnomeVFS.URI anyway.
Loosk good. SHOOT!
I don't have a GNOME CVS account yet, so someone else will have to commit for me! Thanks
Commited. Thanks.