After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347628 - ccBanshee patch 0.2 - Creative Commons License Verification
ccBanshee patch 0.2 - Creative Commons License Verification
Status: RESOLVED OBSOLETE
Product: banshee
Classification: Other
Component: Metadata
git master
Other Linux
: High enhancement
: 0.13.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-15 21:15 UTC by Luke Hoersten
Modified: 2007-08-11 23:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Creative Commons License integration and verification v.0.2 (15.23 KB, patch)
2006-07-15 21:16 UTC, Luke Hoersten
none Details | Review
ccBanshee patch 0.5 (28.26 KB, patch)
2006-07-26 20:52 UTC, Luke Hoersten
none Details | Review
Creative Commons license verification patch 0.6 (28.52 KB, patch)
2006-07-28 23:30 UTC, Luke Hoersten
none Details | Review
Creative Commons license verification patch v. 0.8 (36.79 KB, patch)
2006-08-06 17:10 UTC, Luke Hoersten
none Details | Review
Creative Commons license viewing patch v. 0.9 (36.39 KB, patch)
2006-08-06 17:44 UTC, Luke Hoersten
needs-work Details | Review

Description Luke Hoersten 2006-07-15 21:15:47 UTC
This patch verifies Creative Commons license information and displays it if valid. Information can be found here: http://wiki.creativecommons.org/CcBanshee

The patch, new files and a screenshot are available here:
http://openradix.org/pub/code/ccBanshee.zip
Comment 1 Luke Hoersten 2006-07-15 21:16:53 UTC
Created attachment 68975 [details] [review]
Creative Commons License integration and verification v.0.2
Comment 2 Luke Hoersten 2006-07-26 20:51:13 UTC
The ccBanshee ( http://wiki.creativecommons.org/ccBanshee ) patch is fully functional now and uses my new library cc-sharp ( http://wiki.creativecommons.org/cc-sharp ). The patch is attached and cc-sharp can be downloaded here:
 svn co https://svn.sourceforge.net/svnroot/cctools/cc-sharp

Build cc-sharp using MonoDevelop and move cc-sharp.dll to banshee/cc-sharp/cc-sharp.dll and (install dir)/lib/banshee/cc-sharp.dll

Songs with embedded CC licenses can be found on http://ccmixter.org/

There is a bug in this patch with the TrackProperties.cs (or something related to this):
 (Banshee:25625): Gtk-CRITICAL **: gtk_entry_set_text: assertion `text != NULL' failed
This displays when viewing track metadata with CC metadata but Banshee continues to run fine.
Comment 3 Luke Hoersten 2006-07-26 20:52:20 UTC
Created attachment 69687 [details] [review]
ccBanshee patch 0.5
Comment 4 Luke Hoersten 2006-07-28 23:30:36 UTC
Created attachment 69853 [details] [review]
Creative Commons license verification patch 0.6

Fixed a critical bug with multiple RDF blocks causing the parser to ignore them all. Also updated to the new cc-sharp API.
Comment 5 Luke Hoersten 2006-08-06 17:10:16 UTC
Created attachment 70325 [details] [review]
Creative Commons license verification patch v. 0.8

This patch *just* implements license viewing in Banshee. It uses a separate database table to store the license information and does *no* verification of licenses. There is a plugin for verification which can be obtained at http://wiki.creativecommons.org/ccBanshee
Comment 6 Luke Hoersten 2006-08-06 17:44:21 UTC
Created attachment 70327 [details] [review]
Creative Commons license viewing patch v. 0.9

Minor fixes to match Banshee CVS. Same changes as above patch.
Comment 7 Aaron Bockover 2006-11-21 21:38:51 UTC
Luke, I'm sorry for the delays, but I'd like to go ahead and get this in now. Can you fix it up to work against the latest CVS?
Comment 8 Luke Hoersten 2006-11-21 22:41:48 UTC
Absolutely. I love the direction that Banshee is going. As soon as I finish a compiler I'm working on, I'll bring license viewing up to speed but it may be a few weeks.

Thanks Aaron.
Comment 9 Josiah Ritchie - flickerfly 2007-02-20 19:45:51 UTC
I'm changing the target to 0.12.x because of the feature freeze. Is there an update on this patch? I'd be sad to see this fall from attention. It seems like a good idea.
Comment 10 Luke Hoersten 2007-02-20 20:07:22 UTC
Basically the switch to LibTag# etc changed the code base enough that I didn't have the time to get my patch back up to speed with SVN. It's still in my list of things to do but really my coursework takes priority.

It just gets a little disheartening when you have a fully functional patch that gets ignored long enough to the point where I can't keep it going anymore.
Comment 11 Luke Hoersten 2007-08-11 17:14:34 UTC
Please mark this as "OBSOLETE" and when Gstreamer supports the necessary Creative Commons tags, I will write a new patch and open a new issue.