After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347501 - Leak in bonobo_exception_repoid_to_text()
Leak in bonobo_exception_repoid_to_text()
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonobo
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2006-07-14 12:35 UTC by Kjartan Maraas
Modified: 2006-07-14 14:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
possible fix (1.03 KB, patch)
2006-07-14 12:36 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2006-07-14 12:35:26 UTC 
Coverity reports this and it appears to be correct. Possible fix attached.
Comment 1 Kjartan Maraas 2006-07-14 12:36:50 UTC 
Created attachment 68919 [details] [review]
possible fix
Comment 2 Michael Meeks 2006-07-14 13:29:56 UTC 
looks great to me - thanks :-)
Comment 3 Paolo Borelli 2006-07-14 14:14:06 UTC 
(I haven't checked carefully, just couldn't resist taking a look at the patch from irc)

the patch looks wrong to me though: the bonobo_exception_repoid_to_text() should be inside the 'else' otherwise it's called every time while the g_free is called just inside the 'else'
Comment 4 Kjartan Maraas 2006-07-14 14:46:57 UTC 
Adjusted accordingly and commited. Thanks.