GNOME Bugzilla – Bug 347384
[ghostpad] padtemplates shouldn't be set automatically
Last modified: 2006-07-13 10:48:02 UTC
GhostPads should not set padtemplates automatically. It currently takes the padtemplate of the target pad when we set the target. Several issues: _ the availability and name of the padtemplate do not reflect the ones of the ghostpad _ if the target is a ghostpad itself and we change it's target, the template will not be propagated to the initial ghostpad. Pad templates on ghostpads should be set explicitely.
Created attachment 68852 [details] [review] Proposed patch This patch: _ doesn't set padtemplates automatically when creating a new ghostpad with target, and when changing the target of a ghostpad _ adds a new function gst_ghost_pad_new_with_template, where it is possible to create a ghostpad with a padtemplate
You're kidding, right? Adding new API in a pre-release? Is this a regression? What are the consequences of punting this?
Fine, I won't add the new convenience function. But it stays the same, ghostpads shouldn't take the pad templates of their targets.
Created attachment 68853 [details] [review] updated version without new API I removed the new convenience function. This doesn't break API.
This last patch looks ok!
2006-07-13 Edward Hervey <edward@fluendo.com> * gst/gstghostpad.c: (gst_proxy_pad_set_target_unlocked): GhostPad no longer implicitely use the padtemplates of the targets. Fixes #347384