GNOME Bugzilla – Bug 347310
gnome-nettool shows incorrect Hardware address
Last modified: 2006-08-21 02:58:26 UTC
Please describe the problem: gnome-nettool-1.4.* does not show the correct hardware address for any of the ethernets(eth*). Also the 'State' is shown as inactive even if the interface is up. The Hardware address is displayed as 00:00:00:00:00:00. MTU is either shown as 0 or some junk value. I also tried this with 2.1* but it doesnot seem to be working fine. The 'ifconfig' shows the information correctly. Steps to reproduce: 1. Install RHEL4 Update3 or Suse Linux 10. 2. Run gnome-nettool at the terminal. 3. Select 'Network Device' as eth0 Actual results: The corresponding info shown will be incorrect. Expected results: The info should match with the info from ifconfig Does this happen every time? Yes Other information:
Created attachment 70357 [details] [review] the patch fixes the issue
I'm not able to reproduce it. Even without applying that patch.
Created attachment 70627 [details] [review] this path may be the better one This problem is occuring in 64 bit machines where sizeof(unsigned long) is 8 bytes. Due to this sizeof(struct ifmap)is 24 bytes instead of 16 bytes with padding and sizeof(struct ifreq) is 40 bytes instead of 32 bytes. this causes "ptr += sizeof (ifr->ifr_name) + len" incrementing only 32 bytes but not 40 bytes and not pointing to next interface.
Thanks for the explanation. I'll test it in a 64 bit machine as soon as I can.
Giribabu, Please, take a look at http://live.gnome.org/GnomeLove/SubmittingPatches It's missing a ChangeLog entry. Much better would be include a ChangeLog entry and a NEWS entry. Thanks.
Created attachment 70858 [details] [review] patch with changelog and news entries Germán Poó-Caamaño, thanks for your suggestion
Fixed in CVS. The fix will go into the next patch release. Thank you for your bug report. Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.