After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347295 - [vorbisdec] Pushes before being initialized
[vorbisdec] Pushes before being initialized
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: Edward Hervey
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-12 10:19 UTC by Edward Hervey
Modified: 2006-07-12 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Delays all event pushes until vorbisdec is initialized. (4.98 KB, patch)
2006-07-12 10:20 UTC, Edward Hervey 		committed Details | Review
Addendum to previous patch (2.62 KB, patch)
2006-07-12 12:44 UTC, Edward Hervey 		accepted-commit_now Details | Review

Description Edward Hervey 2006-07-12 10:19:16 UTC 
vorbisdec currently pushes out a lot of events (newsegment, tags) before being properly initialized (able to answer a seek, queries, ...).

It should wait until it is properly initialized before outputting those events.
Comment 1 Edward Hervey 2006-07-12 10:20:47 UTC 
Created attachment 68800 [details] [review]
Delays all event pushes until vorbisdec is initialized.

This patches fixes the behaviour. Works with pitivi, jokosher, gnonlin, totem.
Comment 2 Edward Hervey 2006-07-12 10:38:17 UTC 
2006-07-12  Edward Hervey  <edward@fluendo.com>

        * ext/vorbis/vorbisdec.c: (gst_vorbis_dec_init),
        (gst_vorbis_dec_reset), (vorbis_dec_sink_event),
        (vorbis_handle_comment_packet), (vorbis_handle_type_packet):
        * ext/vorbis/vorbisdec.h:
        Delay sending events (newsegment, tags) until the decoder is properly
        initialized.
        Fixes #347295
Comment 3 Edward Hervey 2006-07-12 12:44:39 UTC 
Created attachment 68810 [details] [review]
Addendum to previous patch

This is an addition to the previous patch.

As soon as tags are found, they are posted on the bus as messages, even though the decoder isn't initialized.
This makes 'make check' happy :)
Comment 4 Edward Hervey 2006-07-12 13:04:46 UTC 
2006-07-12  Edward Hervey  <edward@fluendo.com>

        * ext/vorbis/vorbisdec.c: (gst_vorbis_dec_reset),
        (vorbis_dec_sink_event), (vorbis_handle_comment_packet),
        (vorbis_handle_type_packet):
        Post tag messages on the bus even if we're not initialized.
        If we're not initialized, we still postpone the event pushing of tags.