After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347146 - underline/overstrike spaces
underline/overstrike spaces
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
: 354709 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-10 21:38 UTC by Behdad Esfahbod
Modified: 2006-09-12 01:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Behdad Esfahbod 2006-07-10 21:38:27 UTC 
Currently we don't underline/overstrike spaces.  That should be fixed.

RH bug with test case.

  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198136
Comment 1 Akira TAGOH 2006-09-07 03:05:42 UTC 
*** Bug 354709 has been marked as a duplicate of this bug. ***
Comment 2 Behdad Esfahbod 2006-09-11 14:31:22 UTC 
I'm patching pango to use logical rect for underline/overstroke x and width.  Makes more sense.  The only thing I'm not sure yet is whether I should update ink rect to include underline/overstrike.  We already do that for the y coordinates.    The main problem with it is that all in a sudden we are including trailing whitespace in ink rect.  But that's really what it is...
Comment 3 Behdad Esfahbod 2006-09-11 16:24:37 UTC 
Fixed in HEAD.  Not sure whether I should fix in branch.  I tend to say yes.


2006-09-11  Behdad Esfahbod  <behdad@gnome.org>

        Bug 347146 – underline/overstrike spaces

        * pango/pango-renderer.c (add_underline), (add_strikethrough),
        (pango_renderer_draw_layout_line): Use logical extents for
        x and width of underline/strikethrough, such that trailing spaces are
        correctly handled.

        * pango/pango-layout.c (pango_layout_run_get_extents): Use logical
        rect for underline/strikethrough, and reflect that in run ink extents.

        * pango/pango-layout.c (pango_layout_line_get_extents): Don't
        let runs with empty ink extents affect total ink extents.
Comment 4 Behdad Esfahbod 2006-09-11 20:46:23 UTC 
Committed to pango-1-14 too.
Comment 5 LingNing Zhang 2006-09-12 01:39:37 UTC 
You are quick, I am writing the patch for this bug.
hah
:D
Comment 6 LingNing Zhang 2006-09-12 01:44:01 UTC 
Behdad, please close the same bug in Red Hat Bugzilla.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198136