After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347077 - GLIBMM_PROG_CXX_SUN Macro in sun.m4 underquoted
GLIBMM_PROG_CXX_SUN Macro in sun.m4 underquoted
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: build
2.10.x
Other Linux
: Normal minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks: 347074
 
 
Reported: 2006-07-10 05:07 UTC by Kevin McBride
Modified: 2006-07-16 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed Patch for sun.m4 (390 bytes, patch)
2006-07-10 05:08 UTC, Kevin McBride
none Details | Review
Proposed Addition to ChangeLog (516 bytes, patch)
2006-07-13 13:31 UTC, Kevin McBride
none Details | Review

Description Kevin McBride 2006-07-10 05:07:41 UTC
autoreconf found the GLIBMM_PROG_CXX_SUN Macro in sun.m4 to be "underquoted".  I have attatched a patch that should eliminate the warning about the macro being underquoted.

I have set severity to minor because this bug does not keep glibmm from being built.
Comment 1 Kevin McBride 2006-07-10 05:08:19 UTC
Created attachment 68700 [details] [review]
Proposed Patch for sun.m4
Comment 2 Murray Cumming 2006-07-12 14:50:48 UTC
Excellent. Thanks. Any one should feel free to commit this (with a ChangeLog entry) to HEAD and 2.10.
Comment 3 Jonathon Jongsma 2006-07-12 19:46:37 UTC
is there a branch for 2.10 already?
Comment 4 Murray Cumming 2006-07-12 19:50:12 UTC
Er, nope. And there probably doesn't need to be one yet.
Comment 5 Kevin McBride 2006-07-13 04:23:21 UTC
According to GNOME's FTP server, there is a 2.10 branch already:

-rw-rw-r--    1 1117     1117      3180332 Jun 05 20:58 glibmm-2.10.4.tar.gz
226 Directory send OK.
ftp> pwd
257 "/mirror/gnome.org/sources/glibmm/2.10"
Comment 6 Murray Cumming 2006-07-13 05:57:47 UTC
That's a tarball, not a cvs branch.
Comment 7 Jonathon Jongsma 2006-07-13 11:49:15 UTC
ahh, it looks there is a 2-10 cvs branch for glibmm as well.  For some reason I was thinking about gtkmm, not glibmm.  Sorry for the confusion.
Comment 8 Kevin McBride 2006-07-13 13:31:45 UTC
Created attachment 68867 [details] [review]
Proposed Addition to ChangeLog

I don't have write access to CVS, so I decided to attatch a ChangeLog entry for someone with write access to commit.
Comment 9 Murray Cumming 2006-07-16 19:35:01 UTC
Thanks. Applied to the HEAD and 2.10 branches. Please patch the ChangeLog in future.