After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346797 - Help -> Submit Bug Report menu item does not work
Help -> Submit Bug Report menu item does not work
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on: 346901
Blocks:
 
 
Reported: 2006-07-06 19:25 UTC by Matthew Barnes
Modified: 2013-09-13 00:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (1.81 KB, patch)
2006-07-07 15:13 UTC, Matthew Barnes
reviewed Details | Review
Proposed patch #2 (1.38 KB, patch)
2006-08-07 18:34 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2006-07-06 19:25:53 UTC
Selecting "Submit Bug Report" from the Help menu brings up an error dialog saying "Both the --pid and --appname arguments are required."

Looks like Evolution just needs to update the command-line arguments used to invoke bug-buddy.  The offending code is in the command_submit_bug() function in shell/e-shell-window-commands.c.
Comment 1 André Klapper 2006-07-07 02:10:29 UTC
hmm... are you running the bug-buddy version from cvs HEAD?
Comment 2 Matthew Barnes 2006-07-07 04:27:30 UTC
bug-buddy 2.15.0, and evolution 2.7.3
Comment 3 Matthew Barnes 2006-07-07 15:13:09 UTC
Created attachment 68570 [details] [review]
Proposed patch

This patch supplies the missing bug-buddy arguments and also "GLib-ifies" the command_submit_bug() function a little more.
Comment 4 André Klapper 2006-07-07 16:30:16 UTC
targetting to 2.7; asking harish for patch review, so people can you use bugbuddy again.
Comment 5 Olav Vitters 2006-07-07 16:44:22 UTC
IIRC bug-buddy 2.15.0 can currently only submit crashers. Adding a pid argument makes no sense for regular bug reports (will be treated probably as a crasher). Suggest to wait on the outcome of bug 346901.
Comment 6 Matthew Barnes 2006-07-07 17:15:45 UTC
(In reply to comment #5)

I can confirm that it _is_ treated as a crasher in Bug Buddy.

Perhaps instead of opening Bug Buddy, the "Submit Bug Report" menu item should open a web browser to the configuration string PACKAGE_BUGREPORT (http://bugzilla.gnome.org/enter_bug.cgi?product=Evolution)?
Comment 7 Brent Smith (smitten) 2006-07-08 03:52:48 UTC
bkor is right, bug-buddy in HEAD no longer supports an interface to file non-crasher bugs.
Comment 8 Fernando Herrera 2006-07-24 09:51:22 UTC
I fixed bug-buddy so with the --packege command line argument it is in non-crash mode and works fine with current evolution.
Comment 9 Matthew Barnes 2006-07-26 10:45:28 UTC
Please still consider the patch in comment #3.  It cleans up the code a little bit and uses g_spawn_command_line_async() instead of gnome_execute_async().  Some of the options (e.g. --pid) can be removed for use with bug-buddy 2.15.90.
Comment 10 André Klapper 2006-07-28 13:22:45 UTC
harish, can we please get this patch reviewed and in asap? i'm interested in getting evolution bug reports by bugbuddy. thanks. ;-)
Comment 11 Srinivasa Ragavan 2006-08-07 15:51:25 UTC
matthew, can you give a updated patch with the those options removed. Otherwise it looks fine IMO.
Comment 12 Matthew Barnes 2006-08-07 18:34:49 UTC
Created attachment 70410 [details] [review]
Proposed patch #2

Here's a new, simplified patch for use with bug-buddy 2.15.90.

However, there seems to be some issues with bug-buddy itself.  It does not seem to recognize "evolution" as a valid package.  If I select Help -> Submit Bug Report with this patch applied, I get an error dialog saying:

        Bug Buddy doesn't know how to send a
        suggestion for the application evolution.

But it recognizes "Evolution" (uppercase 'E').  Unfortunately PACKAGE and PACKAGE_NAME are both defined as "evolution" (lowercase 'E'), so I had to hard-code the package name in the bug-buddy invocation command.

I also observed that bug-buddy crashes with a "corrupted double-linked list" from glibc if it's invoked without the --sm-disable option.  But that's a separate bug for bug-buddy.  I just mention it FYI.
Comment 13 Matthew Barnes 2006-08-07 18:47:13 UTC
Allow me to clarify the second paragraph because I changed the patch half-way through writing the comment and didn't proofread very well.

Where I say, "... with this patch applied, I get an error dialog ...", I was speaking from before I changed the patch to pass --package=Evolution instead of --package=evolution to bug-buddy.

The attached patch is the newer version (--package=Evolution) and seems to work correctly, although I would prefer it if bug-buddy recognized "evolution" with a lowercase 'E' so that we could use the PACKAGE constant.
Comment 14 Srinivasa Ragavan 2006-08-21 07:54:36 UTC
fixed to HEAD.