After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346754 - Most parasites saved twice in XCF files
Most parasites saved twice in XCF files
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal minor
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-07-06 12:31 UTC by Henning Makholm
Modified: 2006-07-06 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Henning Makholm 2006-07-06 12:31:03 UTC 
The function xcf_image_save_props() in app/xcf/xcf-save.c contains two (almost) identical calls of

  xcf_check_error (xcf_save_prop (info, image, PROP_PARASITES,
                                      error, image->parasites));

- one comes before the grid has been serialized to a parasite, and the other comes after. As a result, all _other_ parasites than the grid one will get written twice to the XCF file. That does not hurt, but is a bit untidy and wasteful.

The first call can be removed without any ill effects that I can see.
Comment 1 Sven Neumann 2006-07-06 14:33:36 UTC 
Thanks for the report. Fixed in both branches:

2006-07-06  Sven Neumann  <sven@gimp.org>

	* app/xcf/xcf-save.c (xcf_save_image_props): removed redundant
	call to xcf_save_prop() for PROP_PARASITES. Spotted by Henning
	Makholm (bug #346754).