GNOME Bugzilla – Bug 346680
Transparant parts as custom color doesn't work in full screen
Last modified: 2006-08-12 03:01:10 UTC
Choosing to display transparent parts of an image as custom color doesn't work full screen. E.g.: 1. Download http://www.letour.fr/PHOTOS/TDF/2006/300/POSITION.gif 2. Open the image in EOG. 3. Edit > Preferences > Transparent Parts: As custom color: #FFFFFF 4. Press [F11]. Actual results: black backround Expected results: white background Version details: eog-2.14.2-1.fc5.1
Confirming with CVS HEAD. Fullscreen seems to generally ignore the transparency settings and always use black.
Created attachment 68458 [details] [review] patch for 2.14.x This patch is basically a copy of transparency_changed_cb() from eog-window.c to eog-fullscreen.c. I think this should be okay for the gnome-2-14-branch. For CVS HEAD I was planning to add the parsing code to EogScrollView to reduce the code duplication.
Created attachment 68486 [details] [review] patch for 2.15.x This patch adds the capability of loading the settings from GConf directly into EogScrollView and modifies EogWindow and EogFullScreen to use it.
Patch for 2.14.* works for me. Thanks.
EOG 2.14 patch commited. 2006-07-13 Lucas Rocha <lucasr@gnome.org> * libeog/eog-full-screen.c (eog_full_screen_new): make transparency color preferences work on full screen mode (Fixes bug #346680). Patch from Felix Riemann <felix@hsgheli.de>.
Felix, I undertand your code duplication concern in the GNOME 2.15.x patch but the solution given is not good. EogScrollView must be a self-contained widget and should not depend on gconf. The only thing EogScrollView must know is which color to use as transparency for the images (the current API). I suggest you to work on a less intrusive solution like passing the transparency color to EogFullScreen constructor, for example.
Created attachment 69008 [details] [review] new patch for 2.15.x Okay, I tried to change it. I didn't change EogFullScreen's constructor, because I think the change should be quite small (say easily reversible) because of its "short" time to live (eog-ng seems unaffected by this problem). The patch adds the parsing-function privately to EogWindow and a wrapper to EogFullScreen (wraps EogScrollView). Well, I think it's quite large and it might be a consideration to use the 2.14-patch here as well despite of its code duplication.
Patch for 2.14 applied in HEAD. No need for too much effort in a "dead" part of code base. Thanks!