After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346604 - handle possibly corrupt group descriptions
handle possibly corrupt group descriptions
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Windows
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-07-05 04:30 UTC by Kenneth Haley
Modified: 2006-07-07 05:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
list of groups with bad descriptions (2.16 KB, text/plain)
2006-07-05 04:32 UTC, Kenneth Haley
  Details
possibly corrupt descriptions (191.87 KB, application/x-bzip2)
2006-07-06 05:36 UTC, Kenneth Haley
  Details
candidate patch against 0.102. (2.45 KB, patch)
2006-07-06 07:23 UTC, Charles Kerr
committed Details | Review

Description Kenneth Haley 2006-07-05 04:30:21 UTC
After refreshing the group list pan starting complaining about the group descriptions.  What I found is that about 55 of the groups have null and or newline characters in them.  While I don't know the reason for this, it would be nice if pan could quietly handle this.  The best way is probably to replace the bad characters with spaces.
Comment 1 Kenneth Haley 2006-07-05 04:32:40 UTC
Created attachment 68376 [details]
list of groups with bad descriptions

This list gives the group name and whether it containd a null or newline.
Comment 2 Charles Kerr 2006-07-06 04:46:43 UTC
Works For Me (tm).  Could you attach your newsgroups.dsc file?
Comment 3 Kenneth Haley 2006-07-06 05:36:05 UTC
Created attachment 68442 [details]
possibly corrupt descriptions

Here is the file.  I deleted the old file and refreshed the groups to get this one.

(groups.cc:337:load_group_descriptions) I don't understand ""
Comment 4 Charles Kerr 2006-07-06 07:23:04 UTC
Created attachment 68446 [details] [review]
candidate patch against 0.102.

Give this patch a try and see how it goes.

The first thing to test is, do the warnings go away.
The changes to data-impl/groups.cc code should see to that.

The second thing to test is to delete your newsgroups.dsc,
update your groups list, and see if the empty lines are gone.
I was forgetting to convert/sanitize the descriptions to UTF-8.
Comment 5 Kenneth Haley 2006-07-06 22:56:51 UTC
That fixed the problems. Thanks.