GNOME Bugzilla – Bug 346528
Graphical display for ping
Last modified: 2006-11-29 18:14:56 UTC
The following patch adds a bar-graph display for ping. The idea is that you can tell at a glance if there are packets missing or massive variations in RTT. The list view gets hidden behind an expander and labelled "Details". The patch is basically complete, but slightly less than perfect. However, I'm going to be travelling for the next two weeks and decided to put this out for consideration before I leave. It needs some UI tweaking (especially the space around the graph and the font size). Also, the draw_ping_graph function should be broken up and I haven't updated the documentation.
Created attachment 68341 [details] [review] Add a bar-graph to the ping tool.
Created attachment 68342 [details] Obligatory screen shot
Created attachment 69947 [details] [review] New and improved version of the patch. This is the finished version of the patch. Rather than using cairo, the gtk_paint_* calls are used so there are no longer odd fonts. The code has also been reorganised slightly.
Created attachment 69948 [details] [review] The real new patch By "final" I obviously meant "final except for that one small bug". New version.
Created attachment 69949 [details] Updated screen-shot
Now we are in UI/String Freeze, so I will wait until the next cycle to apply this patch. I have some questions, even I haven't looked the patch yet. What will happend if the user choose 100 pings? What will look like the time in the lower bar? On the other hand, I think that "Seq. No." could be replaced for some better word. Yesterday I had one, but I forgot it :-( May be, only Seq. Thanks!
The graph only displays the five most recent pings; regardless of how many are performed in total. I didn't consider the small benefits of a scaling bar-graph to be worth the complications. For large data-sets the summary information is far more useful, which is why I moved it above the bar graph. As for "seq. no." I couldn't think of anything good either, but I'm wide open to suggestions. Just "Number" might be a better option, it should be obvious by looking at them that they form a sequence.
Just a gentle reminder of this patch's existence now that the next cycle is starting. If you decide any work needs to be done to it, I'm more than happy to do it.
Instead of having the last 5 measures, it could be a kind of acumulative graph. Every time with a line more thin, according it gets more pings. In that case it could provide a good picture of the behaviour of the net. Anyway, I committed the patch in HEAD. Please, accept my apologizes of being to slow in apply it. Thanks a lot.