After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346452 - 'approximate quality' returns wrong values
'approximate quality' returns wrong values
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 318376
 
 
Reported: 2006-07-03 10:50 UTC by Stephane Delcroix
Modified: 2006-10-30 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Stephane Delcroix 2006-07-03 10:50:06 UTC 
As a pre-requisite to solve bug #318376, a C# implementation of jpegdump was added to CVS.

For some pictures edited with Gimp, F-Spot returns:
approximate quality = 0
but jpegdump returns the correct value (97)

For (a lot) of other pictures, the value returned by f-spot lightly differ for the value returned by jpegdump, but only by 1 or 2 units (f-spot: 96, jpegdump: 98). but it's not a big deal, this code is about 'guessing' the quality...
Comment 1 Larry Ewing 2006-10-05 03:53:09 UTC 
yeah the C# version needs some debugging, which is why it isn't currently being used.  I'm not sure I have the standalone jpegdump code to compare with anymore.
Comment 2 Stephane Delcroix 2006-10-05 07:22:04 UTC 
for the original jpegdump code, check your mailbox. check also the the patch I made in C for the same issue...
Comment 3 Stephane Delcroix 2006-10-30 15:15:47 UTC 
here's the fix...

 
 			switch (tableindex & 0x0f) {
-			case 1:
+			case 0:
 				table = StandardLuminanceQuantization;
 				break;
-			case 2:
-				table = StandardChromninaceQuantization;
+			case 1:
+				table = StandardChrominanceQuantization;
 				break;
 			default:
 				table = null;

Fixed in CVS