After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346306 - Missing 16x16/stock/net/stock_mail-priority-high.png
Missing 16x16/stock/net/stock_mail-priority-high.png
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2006-06-30 17:03 UTC by Matthew Barnes
Modified: 2006-11-28 20:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Description Matthew Barnes 2006-06-30 17:03:32 UTC 
The stock_mail-priority-high.png icon has gone missing from CVS.  There is no mention of this icon being removed in the ChangeLog.

This icon is used by Evolution for flagging mails as important.  To demonstrate this flaw, open Evolution and right-click on an item in the message list.  Look for the menu item labelled "Mark as Important".  It currently shows the stock "icon-not-found" icon instead of the normal red circle with an exclamation mark.
Comment 1 Rodney Dawes 2006-06-30 18:44:11 UTC 
As per the naming spec, this is emblem-important in the emblems context now. A symlink is created at install time by icon-naming-utils for backward compatibility with the old name used by evolution.
Comment 2 Matthew Barnes 2006-07-06 16:56:09 UTC 
A don't see a symlink for the stock_mail-priority-high.png icon.

I also notice that 16x16/stock/net/Makefile.am does not have an install-data-local stanza (which runs the icon-name-mapping script) like many of the other Makefile.am files in the gnome-icon-theme package do.  Consequently, I suspect this particular symlink is never getting created at install time.

Perhaps this is an oversight from a recent change?

Reopening the bug because I think it needs a second glance.
Comment 3 Rodney Dawes 2006-07-06 17:31:40 UTC 
The symlink is NOT in the same directory where the icon was before. The symlink is under the emblems context where the new icon is. As I said before, everything under stock/ is deprecated and going away. Nothing under stock/ is going to get the migration script in the install-data-local rule. It's not an oversight. The emblem-important icon is there in all sizes.
Comment 4 Rodney Dawes 2006-07-06 17:37:46 UTC 
The install-data-local rule was apparently missing for all the emblems directories as well. This is now fixed.
Comment 5 Matthew Barnes 2006-07-06 17:55:31 UTC 
Rodney, thanks for looking at that and helping me understand what was going on.
Comment 6 Matthias Clasen 2006-11-28 14:47:27 UTC 
Turns out this is the wrong fix.

It causes nautilus to display two "Important" emblems, only one of which works.

Please move the stock_mail-priority-high.png to some other context.
Comment 7 Rodney Dawes 2006-11-28 16:02:54 UTC 
This is the correct fix. If it exposes bugs in Nautilus or other applications, then those bugs need to be fixed as well. The symlink isn't going to move to some other context to work around a bug in Nautilus.
Comment 8 Matthias Clasen 2006-11-28 16:19:20 UTC 
Please, don't be so silly all the time. 
Why do you insist on breaking working desktops ?
Comment 9 Rodney Dawes 2006-11-28 19:35:24 UTC 
Yes. Please stop being silly. Re-read my comment. I don't suggest breaking a working desktop, I suggest fixing a broken one. The fact that the icon doesn't work when selected is a Nautilus bug. Work-arounds aren't fixes.
Comment 10 Matthias Clasen 2006-11-28 20:29:02 UTC 
Can you explain how having two "Important" emblems in nautilus is not broken ?

Even if they both worked...