After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346088 - DoG plugin: preview not updating
DoG plugin: preview not updating
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: libgimp
git master
Other Linux
: High normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-06-28 08:45 UTC by Jakub Friedl
Modified: 2006-08-10 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jakub Friedl 2006-06-28 08:45:00 UTC 
The preview of the Difference of Gaussians filter's effect is updated only if the two radius values are not linked by the chain. If you link both values together and change them, the preview is not updated. To update it, it is necessary to break the chain and change one of the values again.
Comment 1 Sven Neumann 2006-06-28 11:23:51 UTC 
The plug-in code looks correct at first sight. This might be a bug in GimpSizeEntry as found in libgimpwidgets.
Comment 2 weskaggs 2006-07-03 17:44:22 UTC 
This looks very much like bug #107633, which was supposedly fixed three years ago.

I have verified that removing the                 

 g_signal_stop_emission_by_name (widget, "value-changed");

calls from gimp_coordinates_callback() makes the preview update properly.  It is not clear to me that these calls actually do what they were intended to -- they date back to the original gimp_coordinates_foo code committed by mitch on 2000-02-01, in rev 1.11 of gimpwidgets.c.
Comment 3 Sven Neumann 2006-07-05 20:11:02 UTC 
The calls look wrong indeed. They are followed by calls to gimp_size_entry_set_refval(), but that only emits "refval-changed", not the "value-changed" signal that is being stopped here. I think we should remove the calls to g_signal_stop_emission_by_name() as Bill suggested.
Comment 4 Sven Neumann 2006-08-07 13:30:42 UTC 
Increasing priority because we should try to fix the widget behaviour early enough to ensure that this change gets enough testing before GIMP 2.4.
Comment 5 weskaggs 2006-08-10 19:19:26 UTC 
Okay, committed to HEAD.

2006-08-10  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* libgimpwidgets/gimpwidgets.c (gimp_coordinate_callback):
	Don't stop emission of "value-changed" signal.  Fixes
	bug #346088.  Let's see if it breaks anything else...