After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346071 - Node.__setattr_ should raise ReadOnlyError for synthesized attributes
Node.__setattr_ should raise ReadOnlyError for synthesized attributes
Status: RESOLVED FIXED
Product: dogtail
Classification: Deprecated
Component: Framework
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Dogtail Maintainers
Dogtail Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-28 03:29 UTC by Dave Malcolm
Modified: 2006-06-30 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch tp implement this, and test for it in unit tests (13.26 KB, patch)
2006-06-28 03:30 UTC, Dave Malcolm 		committed Details | Review

Description Dave Malcolm 2006-06-28 03:29:38 UTC 
I believe that Node.__setattr_ should raise ReadOnlyError for synthesized attributes: if you set such an attribute, and then get it, you won't get the value you set.

Am about to attach a patch which implements this, plus adds unit tests to cover it.  All unit tests pass.

Also removes the "This is my poor excuse for a unit test." code from tree.py
Comment 1 Dave Malcolm 2006-06-28 03:30:26 UTC 
Created attachment 68099 [details] [review]
Patch tp implement this, and test for it in unit tests
Comment 2 Zack Cerza 2006-06-30 16:37:32 UTC 
Nice; thanks, Dave.
Comment 3 Dave Malcolm 2006-06-30 16:50:17 UTC 
Committed to HEAD