After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346066 - [sunaudiosink] don't override user setting and switch on built-in speakers
[sunaudiosink] don't override user setting and switch on built-in speakers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other opensolaris
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-27 23:50 UTC by Brian Cameron
Modified: 2006-06-28 08:38 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
patch to fix problem (457 bytes, patch)
2006-06-27 23:51 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2006-06-27 23:50:39 UTC
Attaching a patch that fixes an annoying problem with the sunaudiosink.  The sink should not modify the ports value.  If the user has turned off the built-in speakers, then we should not reset it in the prepare function.  This causes the built-in speakers to turn back on anytime the user plays a file (or changes a track in totem, rhythmbox, etc.).
Comment 1 Brian Cameron 2006-06-27 23:51:18 UTC
Created attachment 68094 [details] [review]
patch to fix problem
Comment 2 Tim-Philipp Müller 2006-06-28 08:38:16 UTC
Committed, thanks:

  2006-06-28  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Brian Cameron  <brian dot cameron at sun dot com>

       * sys/sunaudio/gstsunaudiosink.c: (gst_sunaudiosink_prepare):
         Do not modify the ports value. If the user has turned off the
         built-in speakers, then we should not reset it in the prepare
         function, since this causes the built-in speakers to turn
         back on anytime the user changes a track in totem, rhythmbox,
         etc. (#346066).