After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346001 - Whirl and Pinch C & Python version menu path clash
Whirl and Pinch C & Python version menu path clash
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Gimp-Python
git master
Other All
: Normal normal
: 2.4
Assigned To: Manish Singh
GIMP Bugs
Depends on:
Blocks: 351287
 
 
Reported: 2006-06-27 05:27 UTC by Joao S. O. Bueno
Modified: 2006-08-15 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Joao S. O. Bueno 2006-06-27 05:27:42 UTC
it is currentuly impossible to run plug-in-whirl-and-pinch from the GIMP's menus since both the C and Python versions register to filters/distorts/Whirl and Pinch... 
(of course this only happens in C/en GIMP since python-fu is not i18ned yet)
Comment 1 Sven Neumann 2006-06-27 08:03:16 UTC
Why does the Python binding install such a script at all? Does it offer any additional value compared to the C version?
Comment 2 Sven Neumann 2006-06-27 11:59:56 UTC
Actually, I don't see why two procedures can't register under the same name. Shouldn't they both show up then?
Comment 3 Sven Neumann 2006-06-27 13:47:22 UTC
If you ask me, Python-Fu must not install any plug-ins at all as long as the user interface doesn't hold up to our standards. This includes complete internationalization and localization.  I suggest that we disable installation of Python plug-ins for the 2.4 release.
Comment 4 Joao S. O. Bueno 2006-06-28 04:14:17 UTC
I will comment on this on the mailing list, as it is not related to this bug.

As for this bug, yes, I think both should get installed, even with a duplicate file name entry. That would ease things for tiny-fu as well.

And I actually do not see python whirl and pinch as a needed plug-in. There aretons of things that are more fun to do with python scripting than replicating existing functionality. We should check what is broke on it, as it will probably show up elsewhere.
Comment 5 Sven Neumann 2006-06-28 12:04:51 UTC
This fixes one aspect of the problem:

2006-06-28  Sven Neumann  <sven@gimp.org>

	* app/menus/plug-in-menus.c (plug_in_menus_setup): generate unique
	keys so that two procedures can be installed to the same menu entry.
	Addresses bug #346001.
Comment 6 Sven Neumann 2006-08-15 10:44:41 UTC
2006-08-15  Sven Neumann  <sven@gimp.org>

	* plug-ins/pygimp/plug-ins/Makefile.am: moved whirlpinch.py to the
	test_scripts category to prevent it from being installed in stable
	releases (bug #46001).