GNOME Bugzilla – Bug 345784
Crashes on sorting threads by subject
Last modified: 2006-06-27 19:47:12 UTC
When I try to sort headers by subject in Pan .100, it crashes every time. (WinXP) Program received signal SIGSEGV, Segmentation fault. 0x10037a2c in ?? () (gdb) bt
+ Trace 69026
I won't be able to test this on Windows until Monday. Can't reproduce on Linux. That's an interersting backtrace -- I wonder, is Pan scrambling the stack so badly that a backtrace is impossible? Did you compile with -ggdb3 ? Anyway, I'll give this a spin on XP on Monday w/0.101.
Yes, I compiled with -ggdb3, as in readme.mingw. Actually, most of the backtraces I get in Insight look like that. The bug must have something to do with contents of those subjects, because I can sort some newsgroups just fine. Perhaps it's a throwback to the bug fixed for 0.97?
Well now that's helpful, why didn't you mention that before? :) Which groups does it crash on?
That's because I didn't know, honestly. :-) The first three newsgroups I tried crashed, so I didn't check any further. For crashing newsgroups, you can try gmane.science.linguistics.wikipedia.arabic, gmane.science.linguistics.wikipedia.chinese or gmane.science.linguistics.wikipedia.polish on news.gmane.org. Some other groups: pl.hum.polszczyzna, pl.pregierz, alt.chinese.text.big5.
Not crashing for me in Linux, but Pan *is* handling the groups strangely. It appears to save the headers right, but won't reload them. Regarding this crash, I'll have to retry with valgrind to see if there are any memory errors that Linux is treating as non-fatal so that Pan soldiers on. Regarding the missing headers, this sounds suspiciously like #345787 (threading falls apart) which you reported. By any chance was that behavior in the same groups, he asked hopefully? :)
Unfortunately, #345787 happens in all groups.
confirmed for gmane.science.linguistics.wikipedia.chinese on XP. works fine on RHEL4.
d'oh, we're corrupting utf8 strings by stripping out leading whitespace with isalpha() and *pch++ in header_pane.cc::do_collate().
Created attachment 68082 [details] [review] Fix utf8 corruption in the header pane by subject/author sorting.
The above patch seems to fix it. I can consistently crash 0.101 in XP by going to gmane.s.l.wikipedia.chinese, downloading all, and sorting by subject. For some reason it works under RHEL4 though we must surely be corrupting the utf8 string there too. 0.101 + the above patch passes the same test under both Windows and RHEL4. I'll include the patch in 0.102.