GNOME Bugzilla – Bug 345733
calling deprecated procedures crashes gimp
Last modified: 2006-09-19 11:59:18 UTC
Using development version 2.3.9 with win XP. I've got the script installed 'Sharpen smart redux' (which works fine with 2.2.11) When used with 2.3.9 it gives two warning messages about calling depreciated plugings - but proceeds and completes. So it is working and presumably finding the correct plugins - as the image does indeed sharpen. The problem occurs when I go to edit->undo history. This causes a complete freeze and can only be resolved by closing the comlete application. I've tried several times on different files and the error always occurs. Maybe if the script was changed to give the correct plugin calls the problem would disappear - but as yet I don't know how. David
Please attach the script to this bug report. And next time, please try to use something meaningful as a summary.
Created attachment 67895 [details] The 'sharpen smart redux script' As requested
I can't reproduce any problem whatsoever with the script and/or undoing it.
David, it is not unlikely that your problem is not directly related to the script. Can you definitely reproduce it the way you described? Does the Undo History dialog usually work for you? Can you try to perform the script manually and check if that also triggers the problem?
With current CVS, the script freezes whenever it tries to call (or calls) a deprecated procedure. If scrupt-fu.exe is killed by force (e.g. by closing the script-fu window), the corresponding error message ("called deprecated procedure") is displayed. So far, this did happen for gimp-levels-auto (now: gimp-levels-stretch) and gimp-convert-grayscale (now: gimp-image-convert-grayscale). While the script can probably be fxied by changing all calls to the non-deprecated ones, script-fu shouldn't freeze on deprecated procedures. This needs a bit more of research.
The script should definitely be fixed but GIMP should also not freeze for deprecated procedures. Please try to run gimp with the option --pdb-compat-mode=on and report back.
I can't reproduce this either. The script correctly pops two warnings, but works fine otherwise. The windows version seems to crash/block/whatever when it tries to display these messages.
With --pdb-compat-mode=on, the script works. --pdb-compat-mode=off causes a crash of GIMP.
Changing the summary to refelct current state more precisely
*** Bug 356684 has been marked as a duplicate of this bug. ***
*** Bug 356669 has been marked as a duplicate of this bug. ***
Indeed, seems I messed that when refactoring the PDB. Will fix.
Fixed in CVS: 2006-09-19 Michael Natterer <mitch@gimp.org> Fix disabling of deprecated procedures (bug #345733): * app/pdb/gimppdb.c (gimp_pdb_register_procedure): silently drop deprecated procedures if they are disabled via --pdb-compat-mode. * app/plug-in/gimpplugin-message.c (gimp_plug_in_handle_proc_run): remove code that handles deprecated procedures even when they are disabled, the change above makes this impossible. Call plug_in_params_to_args() also if we didn't find the procedure, so the PDB doesn't choke on NULL args.