GNOME Bugzilla – Bug 345624
Deselecting an article doesn't clear out the article pane
Last modified: 2006-06-26 22:27:54 UTC
pan .14.2.91 had a really nice feature where the Body pane would clear out when either the article was deselected in the Header pane or when a different group was selected. I'm not sure why this was originally added, but it is invaluable for when an article is, um, accidentally displayed and then needs to be quickly cleared from sight. The same goes for the Header pane, which would get instantly cleared out as soon as another group was selected (just selected, not even entered into). It would be great to regain this functionality. Thank you. Other information:
Fixed for 0.101.
I'm not really happy with the way this feature works in 0.101. (1) http://lists.gnu.org/archive/html/pan-users/2006-06/msg00112.html lists one side-effect: it breaks double-click to acivate a group. (2) I've gotten used to the lag time between clicking an article in a.b.p.* and when the article arrives. I use that lag to look at the current picture. Clearing the screen on selection-changed breaks that flow. (3) The code is, simply, a mess. We already have a lot of nastiness in tracking mouse events to make 1click activation work, to make select-the-row-underneath-the-right-click-context-menu, and other ugliness that I won't get into here. That said, I still like the idea of a quick-clear feature. I think I'm going to reimplement it by listening for middle-mouse clicks. Since they're currently unused, they don't conflict with *anything*. :)
Created attachment 68003 [details] [review] Patch against 0.101 to use the middle mouse button for quick-clear Test patch against 0.101 with a cleaner implementation of quick-clear.
*** Bug 345862 has been marked as a duplicate of this bug. ***
The new patch works much better IMO.
Charles, the middle button solutions is a good idea. At first I was unsure, because it is common on OS X to map the middle button to activate Apple's Expose' feature (basically a task switcher), but by default Apple's X11 implementation emulates the middle button by holding down the Option key while left-clicking. Since with pan 0.14 you'd have to control-click to deselect an article anyway, your fix require no more keypresses than before. Thank you. I tested the patch and everything looks good except when middle-clicking on a group name. If an article is displayed and you middle-click on an article in the Header pane, the article pane is instantly cleared, which is perfect. However, if you instead middle-click on a group, the header pane is cleared (which I would expect) but the article pane is not. I will re-open this bug (I hope that's ok) just so it doesn't fall through the cracks. Thanks!
Good catch. --- foo 2006-06-26 17:26:40.000000000 -0500 +++ group-pane.cc 2006-06-26 17:26:48.000000000 -0500 @@ -323,6 +323,7 @@ && (event->window == gtk_tree_view_get_bin_window (GTK_TREE_VIEW(treeview)))) { pane->_action_manager.activate_action ("clear-header-pane"); + pane->_action_manager.activate_action ("clear-body-pane"); } return false;