GNOME Bugzilla – Bug 345507
No obvious way to return from Find to main page
Last modified: 2006-10-18 23:44:00 UTC
There needs to be an obvious link when in "Find" mode to return to the main page of subscriptions. The only way I have found so far (besides quiting the application and restarting) is to choose "Find" again from the (Edit > Find) Menu. This is much like using MS "Start" to shutdown windows, not very intuitive. Other information:
Created attachment 72964 [details] Modified gladefile with the button
Hello. I have modified straw gladefile to include the "return to feed list" button. The button handler is the same of the find menuitem. Works fine here. Hope this helps. Regards Leandro Lameiro
Created attachment 74737 [details] [review] Add a button to go back to feed list I added the file as a patch with a Changelog's entry.
The solution if fair simple and improves the usability of straw. May apply the patch into CVS?
Hello Germán and straw-devs. I pinged straw developers about applying my patch and Ryan Skadberg said[1] it is alright, but it would be better if the "Find" menuitem could also change label to "Return to feed list". He would look at it when he finds time. I have a patch for this, working fine, but I'm not sure if it follows the application organization (MVP)... Will sync with CVS and upload... [1] - http://mail.gnome.org/archives/straw-list/2006-October/msg00001.html
I've had this on my todo list for over a week (and its the last thing I want to do before releasing 0.26.1), so if you have a patch, it would be awesome if you uploaded. Not exactly sure of what you mean by follwoing the application's organization though.
Created attachment 74778 [details] [review] Changes the MenuItem to "Return to feed list" (and back to "Find...") when user clicks it. Hello Ryan and straw-devs. Here goes the patch. What I meant on "if my patch follows the application organization" was "if I was changing the right class/method, the one with the responsibility to do it." I think the gladefile patch should still be applied. Regards Leandro Lameiro
Committed both patches.
Created attachment 74978 [details] [review] Patching the patch
And committed the fix.