After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345450 - Multiple jpeg attachments don't display
Multiple jpeg attachments don't display
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
: 345690 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-20 17:11 UTC by walt
Modified: 2006-06-25 03:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to read articles <= 10,000 lines in *.pictures.* newsgroups (1.20 KB, patch)
2006-06-21 05:00 UTC, Charles Kerr
none Details | Review

Description walt 2006-06-20 17:11:13 UTC
When clicking on an article from the header pane, a 'Save File' dialog
pops up if the article has multiple jpeg attachments, but the jpegs
never display in the body pane.

If the same article is entered from the preceding article, by hitting
the spacebar, then all works as expected.
Comment 1 Charles Kerr 2006-06-21 04:59:21 UTC
What's going on here is that Pan does _not_ unconditionally try to read
the article when you click on it.  You don't want to read mp3s, for example.
Right now the rules are:

  If it's less than 5,000 lines,
  or it's got jpg/JPG/jpeg/JPEG/gif/GIF/png/PNG in the subject,
  try to read it.

Attached is a patch that revises this a bit:

  If it's less than 5,000 lines,
  or it's got jpg/JPG/jpeg/JPEG/gif/GIF/png/PNG in the subject,
  or it's less than 10,000 lines and is in a group with "pictures" in its name,
  try to read it.
   
cheers,
Charles
Comment 2 Charles Kerr 2006-06-21 05:00:04 UTC
Created attachment 67765 [details] [review]
patch to read articles <= 10,000 lines in *.pictures.* newsgroups
Comment 3 Charles Kerr 2006-06-21 05:02:06 UTC
Does this do the trick for you?
Comment 4 walt 2006-06-21 14:54:27 UTC
Yes.  Works great now, thanks!
Comment 5 Charles Kerr 2006-06-25 03:14:36 UTC
*** Bug 345690 has been marked as a duplicate of this bug. ***