After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345309 - misplaced g_free in gnome_desktop_file_get_locale_string
misplaced g_free in gnome_desktop_file_get_locale_string
Status: RESOLVED FIXED
Product: desktop-file-utils
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of desktop-file-utils
Maintainers of desktop-file-utils
Depends on:
Blocks:
 
 
Reported: 2006-06-19 12:26 UTC by Pascal Terjan
Modified: 2007-01-22 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
move the g_free inside the branch where we no longer need used_locale (680 bytes, patch)
2006-06-19 12:27 UTC, Pascal Terjan
none Details | Review

Description Pascal Terjan 2006-06-19 12:26:20 UTC
(coverity #2843)

used_locale is freed before testing if encoding is NULL. When encoding is NULL, it is used in the error and then freed again.
Comment 1 Pascal Terjan 2006-06-19 12:27:42 UTC
Created attachment 67625 [details] [review]
move the g_free inside the branch where we no longer need used_locale
Comment 2 Ray Strode [halfline] 2006-11-06 16:49:29 UTC
Looks great, thanks.