GNOME Bugzilla – Bug 345301
[PATCH] gst-plugins-good rtsp for Windows
Last modified: 2006-07-24 13:27:11 UTC
+++ This bug was initially created as a clone of Bug #345295 +++ Package gstreamer rtsp doesn't compile with windows. -added nessessary Windows network stuff -added inet_aton function -tried to make it work with minimal modification to original
Created attachment 67617 [details] rtspconnection for windows
waiting for real patch.
Created attachment 67672 [details] [review] real patch rc1
Created attachment 67674 [details] [review] forgot one ifdef so here is the new
Created attachment 67675 [details] [review] ..and should be final. #ifndef instead of #ifdef
Patch by: Joni Valtanen <joni dot valtanen at movial dot fi> * gst/rtsp/rtspconnection.c: (inet_aton), (rtsp_connection_send), (rtsp_connection_close): Make RTSP plugin compile on windows. Fixes #345301. Some changes to original patch to catch errors better. use ifdef WIN32 instead of ifndef.
Created attachment 67703 [details] [review] rc4 -some error printing -fixed typo (socketclose to closesocket) -properly ifdefs
* gst/rtsp/rtspconnection.c: (inet_aton), (rtsp_connection_send), (rtsp_connection_close), (rtsp_connection_free): Use better G_OS_* macros. Fixes #345301 some more.
Created attachment 67710 [details] [review] Patch to Makefile.am Adds WIN32_LIBS to library files
> Adds WIN32_LIBS to library files Where is WIN32_LIBS set in configure.ac? Couldn't find any reference to it in configure.ac or common/* or anywhere really. Did I miss it?
Created attachment 67837 [details] [review] Patch for current CVS version Added error: RTSP_EWSTARTUP = -7 to file rtspdefs.h. Fixed socketclose to closesocket Patch Makefile.am. See bug 345288 for configure.ac patch.
Created attachment 67839 [details] [review] Fixes to previous rtspdefs.h removed: RTSP_EWSTARTUP = -7 added: RTSP_EWSASTART = -7, RTSP_EWSAVERSION = -8, rtspconnection.c added new error "codes" from rtspdefs.h added g_warning printing to version_error.
Created attachment 67841 [details] [review] More elegant solution replaced closesocket and close in code with one CLOSE_SOCKET. CLOSE_SOCKET is defined in the beginning with ifdef.
* gst/rtsp/Makefile.am: * gst/rtsp/rtspconnection.c: (rtsp_connection_send), (rtsp_connection_close): * gst/rtsp/rtspdefs.h: replaced closesocket and close in code with one CLOSE_SOCKET. Some more cleanups. Fixes #345301.
Created attachment 69469 [details] [review] adds <gst/gstinfo.h> to rtspconnection.c Compiling without debugging in WIN32 complains about GST_DEBUG_OBJECT(...). This helps about it. used versions if something to do with them: gstreamer-0.10.8 gst-plugins-base-0.10.8 gst-plugins-good (cvs)
removed the GST_DEBUG_OBJECT instead, it's not meant to be used in that code since it is supposed to be independant from GStreamer. * gst/rtsp/rtspconnection.c: (rtsp_connection_send): Remove unwanted DEBUG line.