GNOME Bugzilla – Bug 345252
Automatic re-enter not function correctly
Last modified: 2006-06-23 08:24:06 UTC
Please describe the problem: If i press enter on the numeric-pad automatic re-enter not function Steps to reproduce: 1. Press enter with numeric-pad Actual results: Expected results: Does this happen every time? Other information:
mh, and what is exactly “re-enter” ?
I guess Giovanni means auto-indent...
Sorry i've the italian version of gnome ;D Auto-ident it's correct
Does pressing the Numeric Keypad's Enter cause the cursor to go on a new line (without autoindentation) or it does nothing at all? Do you by any chance have gtksourceview installed from source? It would be nice to know if it happens with gtksourceview's test-widget... Steve, Jesse: can someone replicate this? (I just have a laptop here so no keypad...) If yes it would be nice to break into gtk_source_view_key_press_event() and take a look at the event->keyval and event->state values.
I can confirm this. Pressing Enter on the numpad makes the cursor go to the next line without auto indentation. This also happens with the gtksourceview test app.
Ok, moving to sourceview... Jesse, can you take a look at the event->keyval value? My wild guess it's just that we need to add another symbol beside GDK_Return, (though I don't see a GDK_NumPad_Return or something like that)
Found it: GDK_KP_Enter
Created attachment 67738 [details] [review] patch trivial patch (should apply with some offsets because I have other local changes). Can you guys test it?
Created attachment 67844 [details] [review] patch against HEAD Same patch as the previous one, but against CVS HEAD (I didn't see there was already one patch attached) I tested it quickly with the test widget, it works ok.
Please, commit in HEAD and (if we already branched) in branch.
Comitted. I don't think we have branched yet.