Bug 345206 – [textoverlay] crash with non-UTF8 input

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 345206 - [textoverlay] crash with non-UTF8 input


Summary:	[textoverlay] crash with non-UTF8 input


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-base
Version:	0.10.x
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	0.10.9
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-06-17 23:34 UTC by Guillaume Desmottes
Modified:	2006-06-21 18:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
debug output (79.20 KB, application/x-bzip) 2006-06-17 23:35 UTC, Guillaume Desmottes	Details

Description Guillaume Desmottes 2006-06-17 23:34:12 UTC

When i read a mkv video, totem crahs always at the same place.

Like in bug 337076 i don't have any problem with the original video and subtitle file (from which i create the mkv).

I got this message in gdb:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1332024400 (LWP 10781)]
0xb72eac78 in IA__g_markup_escape_text (text=0xb00f3000 "", length=31) at gmarkup.c:1890

The trace:

+ Trace 68902

Thread 15 (Thread -1332024400 (LWP 10781))

#0 IA__g_markup_escape_text
at gmarkup.c line 1890
#1 gst_text_overlay_video_chain
at gsttextoverlay.c line 1336
#2 gst_pad_chain
at gstpad.c line 3221
#3 gst_pad_push
at gstpad.c line 3337
#4 gst_base_transform_chain
at gstbasetransform.c line 1463
#5 gst_pad_chain
at gstpad.c line 3221
#6 gst_proxy_pad_do_chain
at gstghostpad.c line 205
#7 gst_pad_chain
at gstpad.c line 3221
#8 gst_pad_push
at gstpad.c line 3337
#9 gst_queue_loop
at gstqueue.c line 770
#10 gst_task_func
at gsttask.c line 193
#11 g_thread_pool_thread_proxy
at gthreadpool.c line 265
#12 g_thread_create_proxy
at gthread.c line 582
#13 start_thread
from /lib/tls/i686/cmov/libpthread.so.0
#14 clone
from /lib/tls/i686/cmov/libc.so.6

Comment 1 Guillaume Desmottes 2006-06-17 23:35:47 UTC

Created attachment 67554 [details]
debug output

Comment 2 Tim-Philipp Müller 2006-06-21 18:39:57 UTC

 2006-06-21  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/pango/gsttextoverlay.c: (gst_text_overlay_make_utf8),
        (gst_text_overlay_video_chain):
          g_markup_escape_text() REALLY doesn't like non-UTF8 input
          and doesn't validate its input either (and neither did
          textoverlay it seems). Let's do that then and fix #345206.