After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345182 - [neonhttpsrc] fails to compile with libneon 0.26.x
[neonhttpsrc] fails to compile with libneon 0.26.x
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.8
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-17 15:06 UTC by Frédéric L. W. Meunier
Modified: 2006-06-19 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Frédéric L. W. Meunier 2006-06-17 15:06:14 UTC
When trying to compile gst-plugins-bad 0.10.3, I get

/usr/local/src/multimedia/sound/libraries/gst-plugins-bad-0.10.3/ext/neon/gstneonhttpsrc.c: In function `set_proxy':
/usr/local/src/multimedia/sound/libraries/gst-plugins-bad-0.10.3/ext/neon/gstneonhttpsrc.c:630: error: structure has no member named `authinfo'

I have neon 0.26.1.
Comment 1 Tim-Philipp Müller 2006-06-17 16:05:27 UTC
Since libneon is only API-stable within any 0.x series, the configure check is probably wrong and should check for  >= 0.25.1 and < 0.25.99  or so.


However, if we're lucky not much that we need has changed. Could you try this patch?

diff -u -p -r1.13 gstneonhttpsrc.c
--- gstneonhttpsrc.c    29 Apr 2006 15:36:15 -0000      1.13
+++ gstneonhttpsrc.c    17 Jun 2006 16:04:48 -0000
@@ -20,6 +20,10 @@
 #include <string.h>
 #include <unistd.h>

+#ifndef NE_FREE
+#define NEON_026_OR_LATER  1
+#endif
+
 #define HTTP_DEFAULT_HOST        "localhost"
 #define HTTP_DEFAULT_PORT        80
 #define HTTPS_DEFAULT_PORT       443
@@ -627,7 +631,11 @@ set_proxy (const char *uri, ne_uri * par
     goto clear;
   }

+#ifdef NEON_026_OR_LATER
+  if (!parsed->path || parsed->userinfo) {
+#else
   if (!parsed->path || parsed->authinfo) {
+#endif
     goto clear;
   }

Comment 2 Frédéric L. W. Meunier 2006-06-17 16:41:32 UTC
Thanks, it fixes it, but testing with what was suggested by someone, I get:

gst-launch neonhttpsrc location="http://64.236.34.4:80/stream/1040" ! decodebin ! audioconvert ! alsasink
Setting pipeline to PAUSED ...
ERROR: Pipeline doesn't want to pause.
Setting pipeline to NULL ...
FREEING pipeline ...

Is this a GStreamer or neonhttpsrc issue ?
Comment 3 Tim-Philipp Müller 2006-06-19 14:10:38 UTC
> Thanks, it fixes it

Great, thanks for testing. Comitted to CVS HEAD:


 2006-06-19  Tim-Philipp Müller  <tim at centricular dot net>

        * configure.ac:
          Fix check so that future libneon API changes won't break the build.

        * ext/neon/gstneonhttpsrc.c:
          Fix build with libneon-0.26.x (#345182).


> ... but testing with what was suggested by someone, I get:
> 
> gst-launch neonhttpsrc location="http://64.236.34.4:80/stream/1040" ! decodebin ! audioconvert ! alsasink

This should be

 gst-launch -v neonhttpsrc location="http://64.236.34.4:80/stream/1040" ! decodebin ! audioconvert ! audioresample ! alsasink


> Setting pipeline to PAUSED ...
> ERROR: Pipeline doesn't want to pause.
> Setting pipeline to NULL ...
> FREEING pipeline ...
> 
> Is this a GStreamer or neonhttpsrc issue ?

Hard to say, could be anything. If you pass the -v switch as above, the output should tell us where the buffer flow stops.

Also, please also try to replace 'neonhttpsrc' with 'gnomevfssrc' in the above pipeline to see if that works.
Comment 4 Wim Taymans 2006-06-19 14:12:37 UTC
it worked for me.
Comment 5 Frédéric L. W. Meunier 2006-06-19 15:47:39 UTC
> Hard to say, could be anything. If you pass the -v switch as above, the output
> should tell us where the buffer flow stops.

It doesn't report additional messages.

> Also, please also try to replace 'neonhttpsrc' with 'gnomevfssrc' in the above
> pipeline to see if that works.

It works, with or without adding the audioresample part. And using -v, it adds additional messages.