After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345074 - GailNotebook may try to remove wrong GailNotebookPage objects
GailNotebook may try to remove wrong GailNotebookPage objects
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
git master
Other Linux
: High critical
: ---
Assigned To: bill.haneman
bill.haneman
: 341853 345340 351401 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-16 02:56 UTC by Carlos Garnacho
Modified: 2006-08-28 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix this (1.42 KB, patch)
2006-06-16 02:57 UTC, Carlos Garnacho 		none Details | Review

Description Carlos Garnacho 2006-06-16 02:56:11 UTC 
sometimes when removing a tab from epiphany with GNOME_ACCESSIBILITY set I can see the following warning:

** CRITICAL **: gail_notebook_real_remove_gtk: assertion `obj' failed

some investigation showed me that it was trying to get from gail_notebook->page_cache a GailNotebookPage with wrong index, this is caused by reset_cache() decrementing indexes, but gail_notebook->remove_index getting non-updated indexes because of this piece of code:

  g_signal_connect (gtk_notebook_get_nth_page (notebook, index), 
                    "parent_set",
                    G_CALLBACK (gail_notebook_child_parent_set),
                    GINT_TO_POINTER (index));

index is the index the page gets when it's created, when passed as user data to gail_notebook_child_parent_set() it isn't updated.

I'm attaching a patch to fix this issue.
Comment 1 Carlos Garnacho 2006-06-16 02:57:00 UTC 
Created attachment 67462 [details] [review]
patch to fix this
Comment 2 Christian Persch 2006-06-16 12:00:30 UTC 
*** Bug 341853 has been marked as a duplicate of this bug. ***
Comment 3 Don Scorgie 2006-07-19 22:44:54 UTC 
This also affects the new Gtk printing UNIX dialog.  When destroying a printing dialog (in epiphany or my own code), I get:

** (epiphany:17466): CRITICAL **: gail_notebook_real_remove_gtk: assertion `obj' failed

** (epiphany:17466): CRITICAL **: gail_notebook_real_remove_gtk: assertion `obj' failed

** (epiphany:17466): CRITICAL **: gail_notebook_real_remove_gtk: assertion `obj' failed

As the dialog is being destroyed.
Comment 4 Don Scorgie 2006-07-20 19:54:48 UTC 
*** Bug 345340 has been marked as a duplicate of this bug. ***
Comment 5 Don Scorgie 2006-08-10 11:36:56 UTC 
... and the gtk+ about dialog, credits page. (Since critical warnings crash in devel versions, this takes down the app when encountered, which makes it very annoying to test).
Comment 6 Christian Kirbach 2006-08-11 09:14:39 UTC 
came across this as well

patch works for me
Comment 7 Christian Persch 2006-08-15 09:53:42 UTC 
*** Bug 351401 has been marked as a duplicate of this bug. ***
Comment 8 Martin Ammermüller 2006-08-15 15:17:48 UTC 
patch works here for 2.15.91, too.
It's in GARNOME CVS HEAD: http://cvs.gnome.org/viewcvs/garnome/platform/gail/files/

I think this bug should be closed.
Comment 9 Don Scorgie 2006-08-15 15:25:25 UTC 
(In reply to comment #8)
> patch works here for 2.15.91, too.
> It's in GARNOME CVS HEAD:
> http://cvs.gnome.org/viewcvs/garnome/platform/gail/files/
> 
> I think this bug should be closed.
> 

... except the patch hasn't been committed to gail yet.
Comment 10 bill.haneman 2006-08-21 18:48:34 UTC 
Comment on attachment 67462 [details] [review]
patch to fix this

Thanks Carlos for the fix!
I committed myself since today is a tarball release day.
Comment 11 Karsten Bräckelmann 2006-08-28 16:41:09 UTC 
*** Bug 353130 has been marked as a duplicate of this bug. ***
Comment 12 Karsten Bräckelmann 2006-08-28 23:25:16 UTC 
Please have a look at bug 353130.