After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344949 - Inhibit Gnome Power Manager from suspending while burning
Inhibit Gnome Power Manager from suspending while burning
Status: RESOLVED FIXED
Product: nautilus-cd-burner
Classification: Deprecated
Component: cd-burner
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Nautilus CD Burner Maintainers
Nautilus CD Burner Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-15 06:06 UTC by lists
Modified: 2008-01-21 16:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch (4.15 KB, patch)
2006-06-15 16:50 UTC, Fabio Bonelli
needs-work Details | Review
Patch for gpm support (3.41 KB, patch)
2007-12-23 14:56 UTC, Martin Schoen
needs-work Details | Review
Revised patch (3.94 KB, patch)
2008-01-13 11:50 UTC, Martin Schoen
committed Details | Review

Description lists 2006-06-15 06:06:10 UTC
From: https://launchpad.net/distros/ubuntu/+source/nautilus-cd-burner/+bug/49792

All nautilus-cd-burner has to do is call a simple dbus method when burning starts, and a simple dbus method when it's finished. This way Gnome-Power-Manager doesn't auto-suspend or power-down while burning is taking place.

See https://wiki.ubuntu.com/GnomePowerManagerInactiveSleep for more information.
Comment 1 Fabio Bonelli 2006-06-15 16:50:15 UTC
Created attachment 67438 [details] [review]
Patch

Not tested but it should work. At least it compiles. ;-)
Comment 2 William Jon McCann 2006-06-16 18:32:51 UTC
This shouldn't be done by libnautilus-burn but by the nautilus-cd-burner application.  Also, the inhibit cookie should not be global.
Comment 3 Fabio Bonelli 2006-06-17 13:37:46 UTC
Why? This way applications using libnautilus-burn would freely benefit from that.
Comment 4 Pacho Ramos 2007-01-15 12:03:14 UTC
I can burn fully succesfully DVDs using growisofs and suspend2, also when it suspend while growisofs is burning, after resuming, record is resumed succesfully :-)
Comment 5 Martin Schoen 2007-12-23 14:56:23 UTC
Created attachment 101505 [details] [review]
Patch for gpm support

Unfortunately, on my machine a suspend while burning a cd creates a coaster. The attached patch fixes this issue (tested on my machine).
Comment 6 William Jon McCann 2007-12-23 17:03:03 UTC
Comment on attachment 101505 [details] [review]
Patch for gpm support

Cool.  Thanks for looking into this.  A couple comments:

* You should probably put this stuff separate functions.

* Should be able to use nautilus_burn_drive_media_type_get_string instead of the switch block.

* Make sure to line up the variable names in the declarations.

Thanks!
Comment 7 William Jon McCann 2007-12-23 17:04:50 UTC
Oh, and always use an explicit NULL check like this:

if (var != NULL) {
}

Thanks again.
Comment 8 Martin Schoen 2008-01-13 11:50:50 UTC
Created attachment 102723 [details] [review]
Revised patch
Comment 9 William Jon McCann 2008-01-21 16:07:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.