After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344833 - Tracks removed from sources don't disappear
Tracks removed from sources don't disappear
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: High normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 365217 372393 375614 383545 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-14 02:02 UTC by Gabriel Burt
Modified: 2006-12-07 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gabriel Burt 2006-06-14 02:02:48 UTC
When the criteria for a SmartPlaylist changes or a Track no longer matches, it is removed, but if you have looking at that SmartPlaylist, the track doesn't get visibly removed from the list of tracks.  If you click on another source and then back to the SmartPlaylist, it will be gone.
Comment 1 Gabriel Burt 2006-07-06 05:36:17 UTC
This is the most annoying bug in the smart playlists plugin, imo.  It's probably a matter of one function not being called, but I've looked and don't see it.  Any help would be appreciated.
Comment 2 Dominik Meister 2006-07-22 15:09:24 UTC
It seems to be a problem with the playlist model in banshee itself. In SmartPlaylist.cs (line 129) the OnTrackRemoved handler gets called. I tracked this call all through to src/PlaylistModel.cs (banshee-core, line 399). There, a method RemoveTrack() gets called but doesn't do anything. I think the the purpose of this method is to update the model and reflect this changes in the playlist view (like it is done in the overloaded RemoveTrack() method on line 381. This method takes a tree iterator as an additional argument and uses this to delete the track from the model).
So either we have to change the RemoveTrack() method so it does anything useful (if possible with only the track as argument) or we anyhow have to call the other RemoveTrack() method.
Comment 3 Gabriel Burt 2006-10-27 01:35:11 UTC
*** Bug 365217 has been marked as a duplicate of this bug. ***
Comment 4 Gabriel Burt 2006-10-30 05:39:47 UTC
Punting to Aaron, since as far as we can determine, this isn't a SmartPlaylist specific issue.  The answer is, of course, this will probably be a non-issue when the new model-view stuff rolls in.
Comment 5 Gabriel Burt 2006-11-12 05:15:43 UTC
*** Bug 372393 has been marked as a duplicate of this bug. ***
Comment 6 Gabriel Burt 2006-11-15 18:32:21 UTC
*** Bug 375614 has been marked as a duplicate of this bug. ***
Comment 7 Gabriel Burt 2006-12-07 06:31:14 UTC
Fixed in CVS.
Comment 8 Gabriel Burt 2006-12-07 23:19:38 UTC
*** Bug 383545 has been marked as a duplicate of this bug. ***