Bug 344821 – [pitch] controllable properties

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 344821 - [pitch] controllable properties


Summary:	[pitch] controllable properties


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other Linux

Importance:	Normal enhancement
Target Milestone:	0.10.4
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-06-13 22:24 UTC by Wouter Paesen
Modified:	2006-06-14 18:10 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
GstPitch = GstControllable patch (4.58 KB, patch) 2006-06-13 22:25 UTC, Wouter Paesen	none	Details \| Review
Little test application for testing the controllable functionality (2.71 KB, text/plain) 2006-06-13 22:27 UTC, Wouter Paesen		Details
Rewrite of the patch (3.03 KB, patch) 2006-06-14 07:14 UTC, Wouter Paesen	committed	Details \| Review
Sample program to test the functionality (2.71 KB, text/x-csrc) 2006-06-14 07:15 UTC, Wouter Paesen		Details

Description Wouter Paesen 2006-06-13 22:24:52 UTC

This little patch makes the soundtouch based pitch controller controllable
using GstControl.

Some remarks about the changes :
* for some reasong GstControl can _not_ work with float properties
  so i converted all properties to doubles.
* configure.ac should generate GST_CONTROLLABLE_* for linking against
  that lib (which the patch takes care of).

I'll also attach a little test application that can be used to test
the functionality.

Comment 1 Wouter Paesen 2006-06-13 22:25:51 UTC

Created attachment 67303 [details] [review]
GstPitch = GstControllable patch

Comment 2 Wouter Paesen 2006-06-13 22:27:10 UTC

Created attachment 67304 [details]
Little test application for testing the controllable functionality

the app takes as a parameter the type of the audio sink you want to use.

Comment 3 Wouter Paesen 2006-06-14 07:14:12 UTC

Created attachment 67322 [details] [review]
Rewrite of the patch

This rewrite does not convert properties to double.  It will only work 
correctly after patch #344849 is apllied to GstController.

Comment 4 Wouter Paesen 2006-06-14 07:15:35 UTC

Created attachment 67323 [details]
Sample program to test the functionality

Test application that uses float properties instead of double properties.

Comment 5 Tim-Philipp Müller 2006-06-14 18:10:33 UTC

Thanks, committed:

 2006-06-14  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Wouter Paesen  <wouter at kangaroot net>

        * ext/soundtouch/Makefile.am:
        * ext/soundtouch/gstpitch.cc:
          Make pitch element controllable via GstController interface
          (#344821).

        * configure.ac:
          Up core requirements to 0.10.8.1/CVS because earlier
          GstControllers can't handle float properties correctly.
          Check for GstController CFLAGS and LIBS.

        * tests/icles/Makefile.am:
        * tests/icles/pitch-test.c: (main):
          Add small test program for the above (welcome to the 80s!).